fix(filemerge): follow symlinked parent directories instead of refusing#734
Open
facchin21 wants to merge 1 commit into
Open
fix(filemerge): follow symlinked parent directories instead of refusing#734facchin21 wants to merge 1 commit into
facchin21 wants to merge 1 commit into
Conversation
When a parent directory in the write path is a symlink (e.g. ~/.claude/agents pointing to a dotfiles repo), resolve it with filepath.EvalSymlinks and continue checks against the real target directory. Previously, any symlinked parent caused an unconditional refusal, breaking installations for users who manage their Claude Code config via symlinks.
Alan-TheGentleman
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureAtomicParentDirpreviously returned an error when the parent directory was a symlink, blocking installations for users whose Claude Code config subdirectories (e.g.~/.claude/agents) are managed as symlinks to a dotfiles or team config repositoryfilepath.EvalSymlinks, stat the real target, and continue the existing directory and permission checks against the resolved pathTest plan
go test ./internal/components/filemerge/...passesgo test ./...passesggawith~/.claude/agentssymlinked to a real directory:component:sddinstalls successfullyCloses #733