feat(system): add android support and improve temp dir handling#747
Closed
pgtoopx wants to merge 1 commit into
Closed
feat(system): add android support and improve temp dir handling#747pgtoopx wants to merge 1 commit into
pgtoopx wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently, Gentle AI assumes standard Unix paths (like
/tmp) and doesn't recognizeandroidas a supported OS, making it impossible to run on environments like Termux.Changes
androidto the supported OS list ininternal/system/detect.go.androidto usepkg(Termux default) in the platform resolver./tmppaths to useos.TempDir()ininternal/installcmd/resolver.go.Impact & Compatibility
androiddetection.os.TempDir()benefits all systems by respecting environment-specific temporary directories instead of hardcoding/tmp.Verification