Skip to content

fix(sdd-status): verify-report parser skips pending/TODO when line has pass signal #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
statick88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sdd-status): verify-report parser skips pending/TODO when line has pass signal #901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/sddstatus/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,10 @@ func reportLineHasBlocker(line string) bool {
if line == "" {
return false
}
if reportPassNegationPattern.MatchString(line) || reportPendingPattern.MatchString(line) {
if reportPassNegationPattern.MatchString(line) {
return true
}
if reportPendingPattern.MatchString(line) && !reportLineHasPassSignal(line) {
return true
}
if reportCriticalGlyphStatusPattern.MatchString(line) {
Expand Down Expand Up @@ -647,6 +650,9 @@ func reportLineHasPassSignal(line string) bool {
if line == "" {
return false
}
if strings.Contains(line, "✅") {
return true
}
_, value, hasField := reportField(line)
if hasField && reportPassValuePattern.MatchString(stripMarkdownSignal(value)) {
return true
Expand Down
38 changes: 38 additions & 0 deletions internal/sddstatus/status_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,44 @@ func TestResolveApplyVerifyArchiveGates(t *testing.T) {
wantNext: "verify",
wantBlocked: "verify-report.md is not clearly passing.",
},
{
name: "archive ready when verify report has checkmark todo on same line",
seed: func(t *testing.T, root string) {
changeRoot := seedReadyChange(t, root, "thin", "- [x] 1.1 Work\n")
write(t, filepath.Join(changeRoot, "verify-report.md"), "# Verify\nStatus: PASS\n✅ TODO: finish audit\n✅ PENDING: test run\n")
},
wantApply: ApplyAllDone,
wantApplyD: DependencyAllDone,
wantVerify: DependencyAllDone,
wantArchive: DependencyReady,
wantNext: "archive",
},
{
name: "archive blocked when verify report has standalone todo without glyph",
seed: func(t *testing.T, root string) {
changeRoot := seedReadyChange(t, root, "thin", "- [x] 1.1 Work\n")
write(t, filepath.Join(changeRoot, "verify-report.md"), "# Verify\nStatus: PASS\ntodo: security review\n")
},
wantApply: ApplyAllDone,
wantApplyD: DependencyAllDone,
wantVerify: DependencyReady,
wantArchive: DependencyBlocked,
wantNext: "verify",
wantBlocked: "verify-report.md is not clearly passing.",
},
{
name: "archive blocked when verify report mixes checkmark todo and standalone todo",
seed: func(t *testing.T, root string) {
changeRoot := seedReadyChange(t, root, "thin", "- [x] 1.1 Work\n")
write(t, filepath.Join(changeRoot, "verify-report.md"), "# Verify\nStatus: PASS\n✅ TODO: finish audit\ntodo: security review\n")
},
wantApply: ApplyAllDone,
wantApplyD: DependencyAllDone,
wantVerify: DependencyReady,
wantArchive: DependencyBlocked,
wantNext: "verify",
wantBlocked: "verify-report.md is not clearly passing.",
},
{
name: "archive blocked when verify report says status not passed",
seed: func(t *testing.T, root string) {
Expand Down