Skip to content

fix(installer): make engram stop script exit 0 on clean Windows install #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hansell82 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

fix(installer): make engram stop script exit 0 on clean Windows install #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa41ac6
fix(installer): make engram stop script exit 0 on clean Windows install
hansell82 Jun 19, 2026
bbabb6f
test(engram): cover clean stop script exit
Alan-TheGentleman Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/components/engram/download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@ if ($procs) {
Write-Output "WARNING: $($remaining.Count) engram process(es) could not be stopped (access denied or still running). The upgrade may fail if the file is still locked."
}
}
exit 0
`
}

Expand Down
6 changes: 6 additions & 0 deletions internal/components/engram/download_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,4 +1280,10 @@ func TestEngramStopScriptIsDefensive(t *testing.T) {
if strings.Contains(script, "Stop-Process -Force -ErrorAction Stop") {
t.Errorf("stop script must not use -ErrorAction Stop on Stop-Process (reintroduces issue #815/#850)\nscript:\n%s", script)
}

// The clean/no-process path must report success explicitly, regardless of any
// PowerShell status left behind by defensive no-op commands.
if !strings.HasSuffix(strings.TrimSpace(script), "exit 0") {
t.Errorf("stop script must explicitly exit 0 on the clean/no-process path\nscript:\n%s", script)
}
}
Loading