-
Notifications
You must be signed in to change notification settings - Fork 492
fix(install): add PowerShell 5.1 fallback for SHA256 checksum verification #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
decode2
wants to merge
4
commits into
Gentleman-Programming:main
Choose a base branch
from
decode2:fix/install-ps51-getfilehash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−1
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a3c6519
fix(install): add PowerShell 5.1 fallback for SHA256 checksum verific…
decode2 a66caf7
fix(install): correct PowerShell version comment for Get-FileHash
decode2 cb03fcb
test(install): add regression test for .NET SHA256 fallback
decode2 db93938
fix(install): make hash fallback test work without Get-FileHash
decode2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # Test script to verify .NET SHA256 fallback works correctly | ||
| # This ensures the fallback path produces valid SHA256 hashes even when Get-FileHash is unavailable | ||
|
|
||
| $testFile = "$env:TEMP\gentle-ai-hash-test.txt" | ||
| # Use fixed content for deterministic testing | ||
| $testContent = "Gentle AI SHA256 fallback test" | ||
|
|
||
| try { | ||
| # Create test file with UTF-8 encoding (no BOM) | ||
| [System.IO.File]::WriteAllText($testFile, $testContent, [System.Text.UTF8Encoding]::new($false)) | ||
|
|
||
| # Calculate hash using .NET fallback (the path we're testing) | ||
| $sha256 = [System.Security.Cryptography.SHA256]::Create() | ||
| $fileStream = [System.IO.File]::OpenRead($testFile) | ||
| try { | ||
| $hashBytes = $sha256.ComputeHash($fileStream) | ||
| $fallbackHash = [System.BitConverter]::ToString($hashBytes).Replace("-", "").ToLower() | ||
| } finally { | ||
| $fileStream.Close() | ||
| $sha256.Dispose() | ||
| } | ||
|
|
||
| # Verify the hash is valid (64 hex characters for SHA256) | ||
| if ($fallbackHash -match '^[a-f0-9]{64}$') { | ||
| Write-Host "PASS: .NET fallback produces valid SHA256 hash" -ForegroundColor Green | ||
| Write-Host "Hash: $fallbackHash" | ||
|
|
||
| # If Get-FileHash is available, verify both methods match | ||
| if (Get-Command Get-FileHash -ErrorAction SilentlyContinue) { | ||
| $standardHash = (Get-FileHash -Path $testFile -Algorithm SHA256).Hash.ToLower() | ||
| if ($standardHash -eq $fallbackHash) { | ||
| Write-Host "PASS: .NET fallback matches Get-FileHash" -ForegroundColor Green | ||
| } else { | ||
| Write-Host "FAIL: Hash mismatch between Get-FileHash and .NET fallback" -ForegroundColor Red | ||
| Write-Host "Get-FileHash: $standardHash" | ||
| Write-Host ".NET fallback: $fallbackHash" | ||
| exit 1 | ||
| } | ||
| } else { | ||
| Write-Host "INFO: Get-FileHash not available, skipping comparison test" -ForegroundColor Yellow | ||
| } | ||
|
|
||
| exit 0 | ||
| } else { | ||
| Write-Host "FAIL: .NET fallback produced invalid hash format" -ForegroundColor Red | ||
| Write-Host "Got: $fallbackHash" | ||
| Write-Host "Expected: 64 hex characters" | ||
| exit 1 | ||
| } | ||
| } finally { | ||
| # Cleanup | ||
| if (Test-Path $testFile) { | ||
| Remove-Item -Path $testFile -Force | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.