feat(shell): show provider/model in the status bar - #1019
alexandregz wants to merge 1 commit into
Conversation
Co-authored-by: deepseek-v4-flash <deepseek-v4-flash@pi.dev> Generated-By: Pi 0.85.1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe shell bar now constructs selected model identifiers from both provider and model ID. Tests update the model data assertion and rendered footer assertion to use the provider-qualified value. ChangesShell model identity
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The shell bar now displays the intended provider/model identifier, with no unresolved merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The shell status bar showed only the bare model id (e.g.
gpt-5.5), which is ambiguous once more than one provider can serve a model with the same name. It now always shows the fully qualifiedprovider/model(e.g.openai-codex/gpt-5.5).This is a display-only change to the status bar model label. No routing, cost, context, or effort behavior changes.
The change
buildShellBarModelnow composesprovider/model. Inextensions/gentle-shell.ts,modelIdwasmodel?.id ?? "no-model"and is now:The
"no-model"fallback is preserved for the no-model case, and the existingmodel?.optionals foreffort,contextWindowandsubscriptionare untouched.Two test assertions updated in
tests/gentle-shell.test.tsto encode the new contract instead of the old one:buildShellBarModel reads session, model, and footer data—built.modelIdis now"openai-codex/gpt-5.5".gentleShell installs the footer on session_start when a UI exists— the rendered bar regex is now/main ⟡ openai-codex\/gpt-5\.5 · medium/.Rendering code in
lib/shell-bar.tsconsumesmodelIdas an opaque string (bar label and fullscreen Status rail), so no rendering change was required.Test plan
node --experimental-strip-types --check extensions/gentle-shell.ts— parses clean.node --experimental-strip-types --test tests/gentle-shell.test.ts— 29/29 pass.pnpm test:gentle-shellis green; the 10 remaining failures are in unrelated files (gentle-agents,rdd-status-line,sdd-managed-runtime-settlement,sdd-research-capabilities). Verified identical on a clean base checkout (git stash→ same 130 pass / 10 fail), so they are pre-existing and not caused by this diff.Notes
pi-show-provider-gentle-pi, where it is confined to this single line.Summary by CodeRabbit