feat(shell): selectable menus for /gentle:animations and /gentle:background-subagents - #1270
Merged
Merged
Conversation
…gents commands Invoking /gentle:animations or /gentle:background-subagents with no argument now opens a native selectable menu (ctx.ui.select) instead of requiring the sub-action to be typed by hand. The animations menu lists quality/performance/potato/status with the current policy in the title; the background-subagents menu lists status/enable/disable. A dismissed menu does nothing; typed sub-actions, invalid-argument warnings, and the headless status fallback keep their existing behavior. Closes #1268
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1268
Type
Summary
/gentle:animationsand/gentle:background-subagentsopen a native selectable menu (ctx.ui.select) when invoked with no argument, instead of requiring the sub-action to be typed by handquality | performance | potato | statuswith the current policy in the title; the background-subagents menu listsstatus | enable | disableChanges
extensions/gentle-shell.ts/gentle:animationsno-argument invocation opens the selectable menu and applies the chosen policy; description updated.extensions/gentle-ai.ts/gentle:background-subagentsno-argument invocation opens the selectable menu and applies the chosen sub-action; description updated.tests/gentle-shell.test.tsselectonfakeContext; covers the menu applying the chosen policy and the dismissed-menu no-write/no-notice case.tests/background-subagents.test.tsselectingContexthelper; covers the menu applying the chosen sub-action and the dismissed-menu no-write/no-notice case.Test Plan
node --experimental-strip-types --test tests/gentle-shell.test.ts— 95 passednode --experimental-strip-types --test tests/background-subagents.test.ts— 41 passedpnpm run typecheck— no regressionspnpm test— 2,866 passed, 38 skipped, 0 failedctx.hasUI+ctx.ui.select); headless callers keep the status fallbackContributor Checklist
type:*labelSummary by CodeRabbit