Skip to content

Ot modflow#25

Open
jbrezmorf wants to merge 39 commits intomainfrom
Ot_modflow
Open

Ot modflow#25
jbrezmorf wants to merge 39 commits intomainfrom
Ot_modflow

Conversation

@jbrezmorf
Copy link
Copy Markdown
Collaborator

No description provided.

@jbrezmorf
Copy link
Copy Markdown
Collaborator Author

REmove hlavo/deep_model/grid_materials.npz

Comment thread hlavo/composed/composed_model_mock.py
Comment thread hlavo/composed/composed_model_mock.py
Comment thread runs/composed_mock/config.yaml Outdated
n_steps: 3
executable: "mf6"
model_1d:
- longitude: 14.8800
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to:
mock_model_inputs/profile_data

Comment thread runs/composed_mock/config.yaml Outdated
latitude: 50.8800
- longitude: 14.9200
latitude: 50.8900
model_config:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this and all subsequent down under the model_1D.

Comment thread hlavo/deep_model/build_modflow_grid.py Outdated
import numpy as np
import yaml

from qgis_reader import Grid, ModelInputs, RasterLayer
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put basic documentation about preparation of the 3D model into README.md:

  • how to call build_modflow_grid
  • structure of the input file (rather as a commented template ... separate file)
  • meaning of files in the output (working) directory
  • move the config files into separate subdir

Comment thread hlavo/deep_model/one_file.py Outdated
@@ -0,0 +1,37 @@
import numpy as np
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REmove.

Comment thread hlavo/deep_model/model_config.yaml Outdated
# xsection_y_index: 80
# xsection_x_index: 60

unsat:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make config section materials:

materials:
    sand:
        layers: [`Q1_top`, `Q2_top`, ...] # GIS name for the bottom interface of the material block
        conductivity: ..
        porosity: ...
        vG_n: ...
        vG_alpha: ...
    clay:
        ...

Comment thread hlavo/kalman/kalman.py
Comment thread hlavo/kalman/kalman.py Outdated
:param verbose: Whether to print verbose runtime logs
:return: Configured KalmanFilter instance
"""
config_path = Path(config_path).expanduser().resolve()
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test if config_path is instance of Path or string -> read the YAML
or treat config_path as dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants