Skip to content

Add benchmark which tests faults far away.#266

Merged
MFraters merged 2 commits intoGeodynamicWorldBuilder:masterfrom
MFraters:add_fault_benchmark
Jun 15, 2021
Merged

Add benchmark which tests faults far away.#266
MFraters merged 2 commits intoGeodynamicWorldBuilder:masterfrom
MFraters:add_fault_benchmark

Conversation

@MFraters
Copy link
Member

This adds a fault benchmark which also should be able to capture any performance improvements by pull request #264. This is done by having one fault in the region of interest and two outside the region of interest.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #266 (d1c5266) into master (b3eabfb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          74       74           
  Lines        4397     4397           
=======================================
  Hits         4329     4329           
  Misses         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3eabfb...d1c5266. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 15, 2021

Pull Request Test Coverage Report for Build 940426544

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.535%

Totals Coverage Status
Change from base Build 932025341: 0.0%
Covered Lines: 4573
Relevant Lines: 4641

💛 - Coveralls

@MFraters MFraters force-pushed the add_fault_benchmark branch from 9b676c7 to 863b14a Compare June 15, 2021 18:44
@github-actions
Copy link

github-actions bot commented Jun 15, 2021

Benchmark Master Feature Difference (99.9% CI)
Slab interpolation simple none 2.981 ± 0.034 (s=157) 2.981 ± 0.040 (s=147) -0.4% .. +0.5%
Slab interpolation curved simple none 2.935 ± 0.045 (s=160) 2.929 ± 0.043 (s=149) -0.8% .. +0.4%
Spherical slab interpolation simple none 3.150 ± 0.047 (s=140) 3.147 ± 0.041 (s=148) -0.7% .. +0.4%
Slab interpolation simple curved CMS 3.733 ± 0.131 (s=115) 3.745 ± 0.124 (s=128) -1.1% .. +1.8%
Spherical slab interpolation simple CMS 7.355 ± 0.055 (s=64) 7.358 ± 0.058 (s=61) -0.4% .. +0.5%

@MFraters MFraters force-pushed the add_fault_benchmark branch from 863b14a to d1c5266 Compare June 15, 2021 19:09
@MFraters
Copy link
Member Author

I also added the two extra slabs outside the box for the Spherical slab interpolation simple CMS. This has doubled the benchmark time, so I hope #264 brings it back :)

@MFraters MFraters merged commit 092c216 into GeodynamicWorldBuilder:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants