You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I like the simplification. Although it looks the correct to me (same code, just some reorganization), for some reason it fails the debug tests, complaining about the following for the spherical tests: what(): Assert `boundary_points.first[i] <= boundary_points.second[i]` failed in /home/runner/work/WorldBuilder/WorldBuilder/include/world_builder/bounding_box.h at line 264: Bounding Box can't be created: the points' order should be bottom left, top right!
for two spherical tests: 24 - spherical_fault_interpolation_simple_none and 25 - spherical_slab_interpolation_simple_CMS.
This could either indicate that there is some small mistake I am missing or that there may be a bug in the original code. Could you have another quick look at it to see if you can find it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code does
This is hard to read, primarily because to the reader, the association between
xandyis lost. But it's easy to avoid this.Follow-up to #264. @alarshi FYI.