Added content to the Fortran interface section in the API_manual part#826
Open
olihen wants to merge 4 commits intoGeodynamicWorldBuilder:mainfrom
Open
Added content to the Fortran interface section in the API_manual part#826olihen wants to merge 4 commits intoGeodynamicWorldBuilder:mainfrom
olihen wants to merge 4 commits intoGeodynamicWorldBuilder:mainfrom
Conversation
MFraters
reviewed
Jan 24, 2025
Member
MFraters
left a comment
There was a problem hiding this comment.
Thanks for writing this up! I can do a more detailed review later, but a few comments as discussed.
- Could you breakup the chick part into a new page, similair to c++ and aspect? You can mention that page in here so people know that it is there.
- a hint for the
has_output_dirandoutput_dir, if thehas_output_dirvariable is true, the world builder lib will be allowed to write files in that directory. Currently it is just writing the world builder json schema and declarations file to this directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be great if someone could quickly read it, to verify if it would make sense for other users