Extending min depth for plugins within a feature#834
Open
alanjyu wants to merge 2 commits intoGeodynamicWorldBuilder:mainfrom
Open
Extending min depth for plugins within a feature#834alanjyu wants to merge 2 commits intoGeodynamicWorldBuilder:mainfrom
alanjyu wants to merge 2 commits intoGeodynamicWorldBuilder:mainfrom
Conversation
alanjyu
force-pushed
the
extend_min_depth
branch
from
ab7c61a to
c1483c0
Compare
alanjyu
force-pushed
the
extend_min_depth
branch
from
c1483c0 to
14761e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address the issue mentioned in #790, I extended the value of the default minimum depth of a plugin (e.g., compositional field, velocity, temperature, etc.) to the negative maximum value of double numbers. I also overhauled the depth constraint for the continental model so that the plugin is always within the depth range of the feature (the default minimum depth of a feature is still zero).
I plan to extend this feature to other features depending on their setup.
I also renamed the variables min_depth and max_depth to min_depth_entry and max_depth_entry, respectively, to reflect that they are user defined.