Pip Install tests #4
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruffsince it does all of isort, black, flake8, and every other imaginable python lint tool all in one -- it's the current standard (scipy, pandas, jupyter, pytest, pip, mypy... on and on.)I attempted to install with current 'develop' branch, several issues:
To fix this i changed
to
and got a new error:
to fix this per the old
setup.pymethod, i added _version to py-modules, which makes it importable, but still throws when we try to use the hsp2 command.bundling the top-level VERSION file so that it's importable by our tools is tricky -- notice that now our
_version.pymodule lives in the top-level of our site-packages folder:this is not how we are supposed to version our package -- imagine if everyone did this!
Instead we need to find a way to bundle our package so that the version number is both available to modules that need to import/export it, and secondarily make it available for easy modification with future version-bump tooling (I believe this is why it was placed in a VERSION file to begin with).
I believe we should simplify our versioning approach for now and adapt it for tooling once we have consensus for who/how version bumps are made.
This PR has a working distribution that is also a good citizen in our site-packages. However, now our site packages looks like:
In the future we should consider distributing a single package called
hsp2with each of these modules included as part of that single package.