Skip to content

Update design of thread replies separator#6249

Open
gpunto wants to merge 1 commit intov7from
redesign/thread-separator
Open

Update design of thread replies separator#6249
gpunto wants to merge 1 commit intov7from
redesign/thread-separator

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Mar 13, 2026

Goal

Update design of thread replies separator

Implementation

Updated separator text style, background, and add a top/bottom border.

🎨 UI Changes

Before After
Screenshot_20260313_164749 Screenshot_20260313_164434

Testing

Open any thread in the sample

Summary by CodeRabbit

  • UI Improvements
    • Redesigned message thread separator with enhanced visual styling, featuring horizontal dividers and improved text formatting with refined typography.
    • Extended divider component customization by introducing modifier parameter support for greater layout flexibility.

@gpunto gpunto added the pr:improvement Improvement label Mar 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@gpunto gpunto marked this pull request as ready for review March 13, 2026 15:49
@gpunto gpunto requested a review from a team as a code owner March 13, 2026 15:49
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0ab348fd-9c34-4565-8573-9864f9edac73

📥 Commits

Reviewing files that changed from the base of the PR and between 8c51a2d and ada6971.

📒 Files selected for processing (2)
  • stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/StreamHorizontalDivider.kt
  • stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageItem.kt

Walkthrough

The changes enhance the StreamHorizontalDivider composable with an optional modifier parameter and redesign the message thread separator UI by removing gradient backgrounds, adding dividers, updating text styling, and switching to pluralized resource retrieval.

Changes

Cohort / File(s) Summary
UI Component Enhancement
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/StreamHorizontalDivider.kt
Added optional modifier parameter with default value to enable callers to apply custom modifiers to the divider component.
Message Thread Separator Redesign
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageItem.kt
Removed vertical gradient background, replaced LocalContext-based quantity string with pluralStringResource, updated text styling from textSecondary/bodyDefault to chatTextSystem/metadataEmphasis, and added StreamHorizontalDivider elements above and below the separator text with adjusted padding and alignment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A divider stands tall, modifier in hand,
The thread separator takes a new stand,
Gradients fade as dividers appear,
Resources pluralized, styling sincere. 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the primary change: updating the design of the thread replies separator component.
Description check ✅ Passed The description includes key sections (Goal, Implementation, UI Changes with before/after images, and Testing), though some optional sections from the template are incomplete.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch redesign/thread-separator
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.70 MB 0.45 MB 🟡
stream-chat-android-ui-components 10.60 MB 11.00 MB 0.40 MB 🟡
stream-chat-android-compose 12.81 MB 12.04 MB -0.78 MB 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant