Merge develop to v7 (17.03.2026)#6262
Merged
VelikovPetar merged 38 commits intov7from Mar 18, 2026
Merged
Conversation
Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
* Fix delete message not working when offline (SYNC_NEEDED) Co-Authored-By: Claude <noreply@anthropic.com> * Update DeleteMessageListener tests for SYNC_NEEDED remote delete Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
…#6166) * feat: add support for `headingContent` and `footerContent` slots to `Messages` * refactor: address review comments * chore: run `./gradlew apiDump spotlessApply` --------- Co-authored-by: Petar Velikov <petarvelikov95@gmail.com>
* Fix incorrect validation for searchMessages parameters Co-Authored-By: Claude <noreply@anthropic.com> * Fix detekt. --------- Co-authored-by: Claude <noreply@anthropic.com>
* Use cursor-based pagination for search messages Co-Authored-By: Claude <noreply@anthropic.com> * Fix detekt. * Make next internal --------- Co-authored-by: Claude <noreply@anthropic.com>
…ViewModelFactory` (#6187) * Use cursor-based pagination for search messages Co-Authored-By: Claude <noreply@anthropic.com> * Fix detekt. * Add messageSearchSort option to ChannelListViewModel and ChannelViewModelFactory Co-Authored-By: Claude <noreply@anthropic.com> * Add tests for messageSearchSort in ChannelListViewModel Co-Authored-By: Claude <noreply@anthropic.com> * Make next internal * Add messageSearchSort to logs * detekt * detekt --------- Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: adasiewiczr <17440581+adasiewiczr@users.noreply.github.com>
…aders (#6203) * Introduce AsyncImageHeadersProvider. * Introduce AsyncImageHeadersProvider. * Update KDocs * Set interceptorCoroutineContext
* Disable swipe-to-reply for deleted messages Co-Authored-By: Claude <noreply@anthropic.com> * PR remarks. --------- Co-authored-by: Claude <noreply@anthropic.com>
…ng channel queries (#6231) Co-authored-by: Claude <noreply@anthropic.com>
* Fix wrong message type for commands in getMessageType() Co-Authored-By: Claude <noreply@anthropic.com> * Fix KDoc --------- Co-authored-by: Claude <noreply@anthropic.com>
# Conflicts: # metrics/size.json # stream-chat-android-client/src/main/java/io/getstream/chat/android/client/internal/state/plugin/listener/internal/DeleteMessageListenerState.kt # stream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/message/MessageUtils.kt # stream-chat-android-client/src/test/java/io/getstream/chat/android/client/internal/state/plugin/logic/querychannels/internal/QueryChannelsLogicTest.kt # stream-chat-android-client/src/test/java/io/getstream/chat/android/client/utils/message/MessageUtilsTest.kt # stream-chat-android-compose/api/stream-chat-android-compose.api # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/factory/AttachmentsPickerMediaCaptureTabFactory.kt # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/media/CaptureMediaLauncher.kt # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageItem.kt # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatTheme.kt # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/messages/AttachmentsPickerViewModel.kt # stream-chat-android-compose/src/test/kotlin/io/getstream/chat/android/compose/viewmodel/channels/ChannelListViewModelTest.kt # stream-chat-android-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/compose/messages/MessageComposer.kt # stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/contract/internal/CaptureMediaContract.kt # stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/viewmodel/search/SearchViewModel.kt
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
WalkthroughThis PR introduces cursor-based message pagination, refactors message deletion logic with a new Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt (1)
1753-1757:⚠️ Potential issue | 🟡 Minor
searchMessagesKDoc no longer matches runtime validation.Line [1769] allows
offset + sort, but Line [1753] and Line [1756] still document that as invalid.📝 Suggested KDoc patch
- * `@param` offset Pagination offset, cannot be used with sort or next. + * `@param` offset Pagination offset, cannot be used with next. ... - * `@param` next Pagination parameter, cannot be used with non-zero offset. - * `@param` sort The sort criteria applied to the result, cannot be used with non-zero offset. + * `@param` next Pagination parameter, cannot be used with offset. + * `@param` sort The sort criteria applied to the result.As per coding guidelines
**/*.kt: "Document public APIs with KDoc, including thread expectations and state notes".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt` around lines 1753 - 1757, Update the KDoc for the public function searchMessages to match runtime validation: change the `@param` lines so offset is documented as only incompatible with next (remove the "cannot be used with sort or next" wording), document that sort may be used together with offset, and keep next documented as "cannot be used with non-zero offset"; ensure the KDoc entries for offset, limit, next, and sort reflect these exact compatibility rules and mention any thread/state expectations present on the public searchMessages API.stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/channels/ChannelListViewModel.kt (1)
362-363:⚠️ Potential issue | 🟡 MinorMinor typo in log message.
The log message uses the literal string
'query'instead of the variable$query.Proposed fix
- logger.v { "[loadMoreQueryMessages] query: 'query'" } + logger.v { "[loadMoreQueryMessages] query: '$query'" }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/channels/ChannelListViewModel.kt` around lines 362 - 363, The verbose log in loadMoreQueryMessages is printing the literal string 'query' instead of the variable value; update the logger.v call that references currentState.query (variable name query) to interpolate or concatenate the actual query variable (e.g., include query) so the log shows the real query content when calling logger.v in ChannelListViewModel.
🧹 Nitpick comments (6)
stream-chat-android-client/src/test/java/io/getstream/chat/android/client/ChatClientGeneralApiTests.kt (1)
235-235: Use backtick test naming for the renamed test.Please align this changed test name with the repository test naming style.
✏️ Suggested rename
- fun searchMessagesWithNextAndSort() = runTest { + fun `search messages with next and sort`() = runTest {As per coding guidelines
**/src/test/**/*.kt: "Use backtick test names (for example:funmessage list filters muted channels()) for readability".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-client/src/test/java/io/getstream/chat/android/client/ChatClientGeneralApiTests.kt` at line 235, Rename the test function searchMessagesWithNextAndSort to a backtick-styled test name to match the repository style (for example: fun `search messages with next and sort`()) by updating the function declaration in ChatClientGeneralApiTests (the runTest block and contents remain unchanged); ensure any direct references to searchMessagesWithNextAndSort in the test class are updated to the new backtick name so the test runner still discovers and executes it.stream-chat-android-client/src/test/java/io/getstream/chat/android/client/internal/state/plugin/listener/internal/DeleteMessageListenerStateTest.kt (1)
173-305: Consider asserting no local deletion on Success-path preconditions.A small negative verification would lock in that successful preconditions don’t accidentally trigger local deletes.
🧪 Optional test tightening
+import org.mockito.kotlin.never @@ fun `onMessageDeletePrecondition when message has SYNC_NEEDED should return Success`() = runTest { @@ val result = deleteMessageListenerState.onMessageDeletePrecondition(testMessage.id) assertTrue(result is Result.Success) + verify(channelLogic, never()).deleteMessage(any()) } @@ fun `onMessageDeletePrecondition when message is COMPLETED regular should return Success`() = runTest { @@ val result = deleteMessageListenerState.onMessageDeletePrecondition(testMessage.id) assertTrue(result is Result.Success) + verify(channelLogic, never()).deleteMessage(any()) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-client/src/test/java/io/getstream/chat/android/client/internal/state/plugin/listener/internal/DeleteMessageListenerStateTest.kt` around lines 173 - 305, The tests for deleteMessageListenerState.onMessageDeletePrecondition lack negative assertions that ensure no local deletion occurs on Success paths; update the Success-path tests (the ones expecting Result.Success) to also verify that channelLogic.deleteMessage and threadsLogic.deleteMessage are not called (use verify(..., never()) or equivalent) to lock in that successful preconditions don't trigger local deletes; reference the tests invoking deleteMessageListenerState.onMessageDeletePrecondition and assert no interactions with channelLogic.deleteMessage and threadsLogic.deleteMessage where appropriate.stream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/message/MessageUtils.kt (1)
217-236: Prefer removing theComplexConditionsuppression by extracting a named predicate.The suppression can be avoided with a small readability refactor.
♻️ Proposed refactor
-@Suppress("ComplexCondition") `@InternalStreamChatApi` public fun Message.shouldDeleteRemote(currentUserId: String?): Result<Unit> { @@ - if (isError() || isEphemeral() || - syncStatus == SyncStatus.IN_PROGRESS || - syncStatus == SyncStatus.FAILED_PERMANENTLY - ) { + val isLocalOnlyByTypeOrSyncStatus = + isError() || isEphemeral() || syncStatus == SyncStatus.IN_PROGRESS || syncStatus == SyncStatus.FAILED_PERMANENTLY + + if (isLocalOnlyByTypeOrSyncStatus) { val error = Error.GenericError("Message is local-only, don't call DeleteMessage API") return Result.Failure(error) }As per coding guidelines: "Use
@OptInannotations explicitly; avoid suppressions unless documented".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/message/MessageUtils.kt` around lines 217 - 236, Remove the `@Suppress`("ComplexCondition") and replace the inline complex boolean in Message.shouldDeleteRemote with a named predicate variable (e.g., val notPersistedRemotely or shouldDeleteLocally) that captures isError(), isEphemeral(), syncStatus == SyncStatus.IN_PROGRESS, and syncStatus == SyncStatus.FAILED_PERMANENTLY; then use if (notPersistedRemotely) { ... } to preserve behavior. Keep the `@InternalStreamChatApi` annotation and existing logic around isModerationError(...) and the Error.ThrowableError creation unchanged. Ensure no other suppressions are added.stream-chat-android-ui-components/src/test/kotlin/io/getstream/chat/android/ui/viewmodels/search/SearchViewModelTest.kt (1)
178-180: Unnecessarysuspendmodifier on mock configuration.The
givenRepositorySelectChannelsfunction only configures a mock withwhenever(...) doReturn ...—it doesn't actually invoke the suspend function. Thesuspendmodifier adds unnecessary complexity to the builder pattern.♻️ Suggested fix
- suspend fun givenRepositorySelectChannels(channels: List<Channel> = emptyList()) = apply { + fun givenRepositorySelectChannels(channels: List<Channel> = emptyList()) = apply { whenever(repositoryFacade.selectChannels(any<List<String>>())) doReturn channels }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-ui-components/src/test/kotlin/io/getstream/chat/android/ui/viewmodels/search/SearchViewModelTest.kt` around lines 178 - 180, The helper function givenRepositorySelectChannels is marked suspend unnecessarily; change its signature to a regular (non-suspending) function so it only configures the mock without requiring a coroutine context. Update the function declaration for givenRepositorySelectChannels(...) to remove the suspend modifier and keep the body as-is (whenever(repositoryFacade.selectChannels(any<List<String>>())) doReturn channels), and adjust any test callers to no longer call it from a coroutine if they do.stream-chat-android-compose/api/stream-chat-android-compose.api (1)
945-945: Add explicit migration notes for the updated public signatures.Line 945, Line 2440, Line 4119, and Line 4159 introduce signature/constructor parameter changes in public APIs. Please add precise migration entries (new params + ordering) in v7 migration/changelog docs.
Based on learnings: In GetStream/stream-chat-android v7, breaking API changes are acceptable, but migration paths should be documented in MIGRATION_TO_V7.md/CHANGELOG.
Also applies to: 2440-2440, 4119-4120, 4159-4160
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-compose/api/stream-chat-android-compose.api` at line 945, Update the v7 migration docs to document the changed public signatures introduced (notably the ChannelsScreen composable signature shown as ChannelsScreen(Lio/getstream/chat/android/compose/viewmodel/channels/ChannelViewModelFactory;Ljava/lang/String;Ljava/lang/String;ZLio/getstream/chat/android/compose/ui/channels/SearchMode;... ) and the other changed constructors at the same commits), by adding precise migration notes listing each new parameter, their types, ordering, default/nullable behavior, and example call-site before/after; add these entries to MIGRATION_TO_V7.md and CHANGELOG (or the project's v7 migration doc) so callers know how to update usages of ChannelsScreen and the other changed constructors.stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/images/StreamImageLoaderFactory.kt (1)
62-69: Consider using a more idiomatic constructor pattern.The secondary constructor that mutates a
varafter delegating to the primary constructor works but is unconventional. A cleaner approach would be to make the primary constructor accept both parameters with defaults.However, this is acceptable for backward compatibility since the existing primary constructor signature must be preserved.
Alternative approach (optional)
public class StreamImageLoaderFactory( + private val interceptors: List<Interceptor> = emptyList(), private val builder: ImageLoader.Builder.() -> Unit = {}, ) : SingletonImageLoader.Factory { - - /** - * Creates a [StreamImageLoaderFactory] with additional [Interceptor]s... - */ - public constructor( - interceptors: List<Interceptor>, - builder: ImageLoader.Builder.() -> Unit = {}, - ) : this(builder) { - this.interceptors = interceptors - } - - private var interceptors: List<Interceptor> = emptyList()Note: This would be a breaking change for binary compatibility, so the current approach may be intentional.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/images/StreamImageLoaderFactory.kt` around lines 62 - 69, Change the class to accept interceptors in the primary constructor instead of mutating a var from the secondary one: add a parameter interceptors: List<Interceptor> = emptyList() to the primary constructor of StreamImageLoaderFactory and initialize the property from that parameter, then remove the secondary constructor that sets this.interceptors; update or remove the private var interceptors declaration to be initialized from the constructor parameter (or make it val if immutable). This preserves behavior but uses the more idiomatic constructor pattern and keeps the existing primary constructor body intact for backward-compatibility considerations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/utils/CapabilitiesHelper.kt`:
- Around line 64-67: Update the KDoc for the public API that determines reply
eligibility to reflect the new deleted-message precondition: document that
replies are only allowed when replyEnabled is true, the message is synced
(message.isSynced()), the message is not deleted (message.isDeleted() == false),
and the user has the QUOTE_MESSAGE capability
(ownCapabilities.contains(ChannelCapabilities.QUOTE_MESSAGE)); locate the KDoc
for the function/property that returns the Boolean (the expression using
replyEnabled, message.isSynced(), message.isDeleted(), and
ChannelCapabilities.QUOTE_MESSAGE) and add a short note about thread/state
expectations and that deleted messages are excluded from replies.
In `@stream-chat-android-ui-components/api/stream-chat-android-ui-components.api`:
- Around line 5212-5213: Update the changelog to document the public API
constructor signature change for SearchViewModel.State: add an entry under the
"⚠️ Changed" section for the stream-chat-android-ui-components component noting
that the SearchViewModel.State constructor signature was changed (list the new
parameter order/types as shown in the API: (String, Boolean, List, Boolean,
Boolean, String) and mention that a synthetic/kotlin DefaultConstructorMarker
overload was added), and include guidance for users migrating any direct uses of
the old constructor to the new parameter set.
---
Outside diff comments:
In
`@stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt`:
- Around line 1753-1757: Update the KDoc for the public function searchMessages
to match runtime validation: change the `@param` lines so offset is documented as
only incompatible with next (remove the "cannot be used with sort or next"
wording), document that sort may be used together with offset, and keep next
documented as "cannot be used with non-zero offset"; ensure the KDoc entries for
offset, limit, next, and sort reflect these exact compatibility rules and
mention any thread/state expectations present on the public searchMessages API.
In
`@stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/channels/ChannelListViewModel.kt`:
- Around line 362-363: The verbose log in loadMoreQueryMessages is printing the
literal string 'query' instead of the variable value; update the logger.v call
that references currentState.query (variable name query) to interpolate or
concatenate the actual query variable (e.g., include query) so the log shows the
real query content when calling logger.v in ChannelListViewModel.
---
Nitpick comments:
In
`@stream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/message/MessageUtils.kt`:
- Around line 217-236: Remove the `@Suppress`("ComplexCondition") and replace the
inline complex boolean in Message.shouldDeleteRemote with a named predicate
variable (e.g., val notPersistedRemotely or shouldDeleteLocally) that captures
isError(), isEphemeral(), syncStatus == SyncStatus.IN_PROGRESS, and syncStatus
== SyncStatus.FAILED_PERMANENTLY; then use if (notPersistedRemotely) { ... } to
preserve behavior. Keep the `@InternalStreamChatApi` annotation and existing logic
around isModerationError(...) and the Error.ThrowableError creation unchanged.
Ensure no other suppressions are added.
In
`@stream-chat-android-client/src/test/java/io/getstream/chat/android/client/ChatClientGeneralApiTests.kt`:
- Line 235: Rename the test function searchMessagesWithNextAndSort to a
backtick-styled test name to match the repository style (for example: fun
`search messages with next and sort`()) by updating the function declaration in
ChatClientGeneralApiTests (the runTest block and contents remain unchanged);
ensure any direct references to searchMessagesWithNextAndSort in the test class
are updated to the new backtick name so the test runner still discovers and
executes it.
In
`@stream-chat-android-client/src/test/java/io/getstream/chat/android/client/internal/state/plugin/listener/internal/DeleteMessageListenerStateTest.kt`:
- Around line 173-305: The tests for
deleteMessageListenerState.onMessageDeletePrecondition lack negative assertions
that ensure no local deletion occurs on Success paths; update the Success-path
tests (the ones expecting Result.Success) to also verify that
channelLogic.deleteMessage and threadsLogic.deleteMessage are not called (use
verify(..., never()) or equivalent) to lock in that successful preconditions
don't trigger local deletes; reference the tests invoking
deleteMessageListenerState.onMessageDeletePrecondition and assert no
interactions with channelLogic.deleteMessage and threadsLogic.deleteMessage
where appropriate.
In `@stream-chat-android-compose/api/stream-chat-android-compose.api`:
- Line 945: Update the v7 migration docs to document the changed public
signatures introduced (notably the ChannelsScreen composable signature shown as
ChannelsScreen(Lio/getstream/chat/android/compose/viewmodel/channels/ChannelViewModelFactory;Ljava/lang/String;Ljava/lang/String;ZLio/getstream/chat/android/compose/ui/channels/SearchMode;...
) and the other changed constructors at the same commits), by adding precise
migration notes listing each new parameter, their types, ordering,
default/nullable behavior, and example call-site before/after; add these entries
to MIGRATION_TO_V7.md and CHANGELOG (or the project's v7 migration doc) so
callers know how to update usages of ChannelsScreen and the other changed
constructors.
In
`@stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/images/StreamImageLoaderFactory.kt`:
- Around line 62-69: Change the class to accept interceptors in the primary
constructor instead of mutating a var from the secondary one: add a parameter
interceptors: List<Interceptor> = emptyList() to the primary constructor of
StreamImageLoaderFactory and initialize the property from that parameter, then
remove the secondary constructor that sets this.interceptors; update or remove
the private var interceptors declaration to be initialized from the constructor
parameter (or make it val if immutable). This preserves behavior but uses the
more idiomatic constructor pattern and keeps the existing primary constructor
body intact for backward-compatibility considerations.
In
`@stream-chat-android-ui-components/src/test/kotlin/io/getstream/chat/android/ui/viewmodels/search/SearchViewModelTest.kt`:
- Around line 178-180: The helper function givenRepositorySelectChannels is
marked suspend unnecessarily; change its signature to a regular (non-suspending)
function so it only configures the mock without requiring a coroutine context.
Update the function declaration for givenRepositorySelectChannels(...) to remove
the suspend modifier and keep the body as-is
(whenever(repositoryFacade.selectChannels(any<List<String>>())) doReturn
channels), and adjust any test callers to no longer call it from a coroutine if
they do.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 9efac234-fc72-43e5-a8e2-6f2257b70b45
⛔ Files ignored due to path filters (4)
stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.messages_SelectedMessageMenuTest_my_message.pngis excluded by!**/*.pngstream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.messages_SelectedMessageMenuTest_my_message_in_dark_mode.pngis excluded by!**/*.pngstream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.messages_SelectedMessageMenuTest_their_message.pngis excluded by!**/*.pngstream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.messages_SelectedMessageMenuTest_their_message_in_dark_mode.pngis excluded by!**/*.png
📒 Files selected for processing (48)
.github/workflows/pr-checks.yml.github/workflows/pr-cleanup.yaml.github/workflows/pr-quality.yml.github/workflows/publish-new-version.yml.github/workflows/sdk-size-checks.yml.github/workflows/sdk-size-updates.ymlREADME.mdbuild.gradle.ktsgradle.propertiesstream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/DtoMapping.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/internal/offline/plugin/listener/internal/DeleteMessageListenerDatabase.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/internal/state/plugin/listener/internal/DeleteMessageListenerState.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/internal/state/plugin/logic/querychannels/internal/QueryChannelsLogic.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/socket/SocketFactory.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/internal/MessageUtils.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/message/MessageUtils.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/ChatClientGeneralApiTests.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/api2/mapping/DtoMappingTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/internal/offline/plugin/listener/internal/DeleteMessageListenerDatabaseTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/internal/state/plugin/listener/internal/DeleteMessageListenerStateTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/internal/state/plugin/logic/querychannels/internal/QueryChannelsLogicTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/socket/SocketFactoryTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/utils/internal/MessageUtilsTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/utils/message/MessageUtilsTest.ktstream-chat-android-compose/api/stream-chat-android-compose.apistream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channels/ChannelsScreen.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageContainer.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/Messages.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatTheme.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/util/ImageHeadersInterceptor.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/util/StreamCoilImageLoaderFactory.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/channels/ChannelListViewModel.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/channels/ChannelViewModelFactory.ktstream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/messages/AttachmentsPickerViewModel.ktstream-chat-android-compose/src/test/kotlin/io/getstream/chat/android/compose/util/extensions/MessageOptionItemVisibilityTest.ktstream-chat-android-compose/src/test/kotlin/io/getstream/chat/android/compose/viewmodel/channels/ChannelListViewModelTest.ktstream-chat-android-ui-common/api/stream-chat-android-ui-common.apistream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/helper/AsyncImageHeadersProvider.ktstream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/images/StreamImageLoaderFactory.ktstream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/utils/CapabilitiesHelper.ktstream-chat-android-ui-common/src/main/res/xml/stream_filepaths.xmlstream-chat-android-ui-common/src/test/kotlin/io/getstream/chat/android/ui/common/utils/CapabilitiesHelperTest.ktstream-chat-android-ui-components/api/stream-chat-android-ui-components.apistream-chat-android-ui-components/detekt-baseline.xmlstream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/viewmodel/search/SearchViewModel.ktstream-chat-android-ui-components/src/test/kotlin/io/getstream/chat/android/ui/feature/messages/list/internal/MessageListViewExtensionsKtTest.ktstream-chat-android-ui-components/src/test/kotlin/io/getstream/chat/android/ui/viewmodels/search/SearchViewModelTest.kt
💤 Files with no reviewable changes (2)
- stream-chat-android-ui-components/detekt-baseline.xml
- stream-chat-android-client/src/test/java/io/getstream/chat/android/client/utils/internal/MessageUtilsTest.kt
Comment on lines
+64
to
+67
| ): Boolean = replyEnabled && | ||
| message.isSynced() && | ||
| !message.isDeleted() && | ||
| ownCapabilities.contains(ChannelCapabilities.QUOTE_MESSAGE) |
There was a problem hiding this comment.
KDoc is missing the new deleted-message precondition.
Line [66] now blocks replies for deleted messages, but the KDoc still lists only sync/capability/UI-flag conditions.
📝 Suggested KDoc patch
* A reply is allowed when:
* - Reply functionality is enabled in the UI configuration
* - The message has been successfully synced with the backend
+ * - The message is not deleted
* - The user has the capability to quote messages in the channelAs per coding guidelines **/*.kt: "Document public APIs with KDoc, including thread expectations and state notes".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/utils/CapabilitiesHelper.kt`
around lines 64 - 67, Update the KDoc for the public API that determines reply
eligibility to reflect the new deleted-message precondition: document that
replies are only allowed when replyEnabled is true, the message is synced
(message.isSynced()), the message is not deleted (message.isDeleted() == false),
and the user has the QUOTE_MESSAGE capability
(ownCapabilities.contains(ChannelCapabilities.QUOTE_MESSAGE)); locate the KDoc
for the function/property that returns the Boolean (the expression using
replyEnabled, message.isSynced(), message.isDeleted(), and
ChannelCapabilities.QUOTE_MESSAGE) and add a short note about thread/state
expectations and that deleted messages are excluded from replies.
Comment on lines
+5212
to
+5213
| public fun <init> (Ljava/lang/String;ZLjava/util/List;ZZLjava/lang/String;)V | ||
| public synthetic fun <init> (Ljava/lang/String;ZLjava/util/List;ZZLjava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Looking for migration/changelog files..."
docs="$(fd -HI '^(MIGRATION_TO_V7\.md|CHANGELOG(\.md)?)$' || true)"
if [ -z "${docs}" ]; then
echo "No MIGRATION_TO_V7.md/CHANGELOG(.md) files found."
exit 0
fi
echo "Scanning docs for SearchViewModel/State API change mentions..."
while IFS= read -r f; do
echo "----- ${f} -----"
rg -n "SearchViewModel|SearchViewModel\\$State|search state|cursor|pagination|messageSearchSort" "${f}" || true
done <<< "${docs}"Repository: GetStream/stream-chat-android
Length of output: 262
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Checking for migration and changelog files ==="
fd -HI '^(MIGRATION_TO_V7\.md|MIGRATION\.md|CHANGELOG\.md)$' 2>/dev/null || echo "No files found"
echo ""
echo "=== Examining the API file around lines 5212-5213 and 5219-5220 ==="
if [ -f "stream-chat-android-ui-components/api/stream-chat-android-ui-components.api" ]; then
echo "Lines 5210-5225:"
sed -n '5210,5225p' "stream-chat-android-ui-components/api/stream-chat-android-ui-components.api" | cat -n
fi
echo ""
echo "=== Searching CHANGELOG for SearchViewModel mentions ==="
if [ -f "CHANGELOG.md" ]; then
rg -A 3 -B 1 "SearchViewModel" CHANGELOG.md || echo "No SearchViewModel mentions found in CHANGELOG"
fi
echo ""
echo "=== Checking for MIGRATION_TO_V7.md ==="
if [ -f "MIGRATION_TO_V7.md" ]; then
echo "File exists. Searching for SearchViewModel or State changes..."
rg -A 3 -B 1 "SearchViewModel|State|cursor|pagination|messageSearchSort" MIGRATION_TO_V7.md || echo "No relevant mentions found"
else
echo "MIGRATION_TO_V7.md not found"
fiRepository: GetStream/stream-chat-android
Length of output: 1637
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Checking git branch ==="
git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "Unable to determine branch"
echo ""
echo "=== Looking for migration or documentation files in the PR ==="
fd -HI 'MIGRATION|migration' -t f 2>/dev/null | head -20
echo ""
echo "=== Checking recent CHANGELOG entries for any v7 migration context ==="
if [ -f "CHANGELOG.md" ]; then
head -50 CHANGELOG.md | cat -n
fi
echo ""
echo "=== Searching for SearchViewModel in source code to understand the change ==="
fd -t f -e kt -e java 'SearchViewModel' | head -5 | while read f; do
echo "--- Found: $f ---"
grep -n "constructor\|fun State\|class State" "$f" 2>/dev/null | head -10 || true
doneRepository: GetStream/stream-chat-android
Length of output: 2164
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Reading SearchViewModel.kt State class definition ==="
if [ -f "stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/viewmodel/search/SearchViewModel.kt" ]; then
wc -l "stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/viewmodel/search/SearchViewModel.kt"
echo ""
sed -n '190,230p' "stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/viewmodel/search/SearchViewModel.kt" | cat -n
fi
echo ""
echo "=== Checking git diff to see what changed in API ==="
git diff HEAD~1 stream-chat-android-ui-components/api/stream-chat-android-ui-components.api 2>/dev/null | head -100 || echo "Unable to get git diff"
echo ""
echo "=== Checking if this is a major version branch ==="
git branch -a 2>/dev/null | grep -i "v7\|main\|develop" || echo "Unable to determine branches"Repository: GetStream/stream-chat-android
Length of output: 1391
Document this public API signature change in CHANGELOG.md.
The SearchViewModel.State constructor signature change is not documented. Add an entry to the "stream-chat-android-ui-components component in CHANGELOG.md describing the parameter modifications to State so users upgrading have clear visibility.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@stream-chat-android-ui-components/api/stream-chat-android-ui-components.api`
around lines 5212 - 5213, Update the changelog to document the public API
constructor signature change for SearchViewModel.State: add an entry under the
"⚠️ Changed" section for the stream-chat-android-ui-components component noting
that the SearchViewModel.State constructor signature was changed (list the new
parameter order/types as shown in the API: (String, Boolean, List, Boolean,
Boolean, String) and mention that a synthetic/kotlin DefaultConstructorMarker
overload was added), and include guidance for users migrating any direct uses of
the old constructor to the new parameter set.
gpunto
approved these changes
Mar 17, 2026
# Conflicts: # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/Messages.kt
# Conflicts: # stream-chat-android-compose/api/stream-chat-android-compose.api
|
andremion
approved these changes
Mar 18, 2026
Contributor
|
🚀 Available in v7.0.0-beta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Merge
developtov7Implementation
Merge
developtov7Testing
Everything should work
Summary by CodeRabbit
Release Notes
New Features
isBackPressEnabledparameterBug Fixes
Chores