feat(verify): report the verified rate per product, not just per SKU - #55
Merged
Conversation
78% of the smartphone set is regional and RAM variants of the same phone: 57,216 records stand for 20,594 actual models, with slugs like "…k61-2020-latam-q630ha-…-costa-rica-4gb-128gb". No source documents an individual SKU, so counting verification per record measures the shape of the import rather than how well the products are sourced. `status` now also aggregates by model — variants collapse onto their base model, a standalone record is its own model, and a model counts as verified once any of its SKUs is, since the variants of one phone share a provenance. The per-record figures are unchanged and still reported; this is a second view of the same verifications, not a replacement. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The verified rate is measured per record, but most records are not distinct products. In the smartphone set:
Slugs look like
lg-lmq630ha-k-series-k61-2020-td-lte-latam-q630ha-sady36-costa-rica-4gb-128gb. No source documents an individual SKU — manufacturer pages for one regional RAM configuration do not exist, and a probe of 200 sampled models found an exact-title Wikipedia article for 3% of them. So the per-record figure measures the shape of the import, not how well the products are sourced.Measured over the current smartphone data:
What changed
statusnow also aggregates by model:models,verified_models,verified_models_pct, intotalsand per categoryThe per-record figures are unchanged and still reported — this is a second view of the same verifications, not a replacement, and nothing about promotion changes.
Additive fields only, so
schemastays at 1 and existing consumers keep working. Two regression tests cover the variant collapse and the standalone case;tests/verifyis 53 passed.TechAPI side (homepage rendering): GetTechAPI/TechAPI#151
Refs #1