Skip to content

Agent A: price orders in an explicit currency#7

Closed
RollNuts wants to merge 2 commits into
mainfrom
demo/currency-required-param
Closed

Agent A: price orders in an explicit currency#7
RollNuts wants to merge 2 commits into
mainfrom
demo/currency-required-param

Conversation

@RollNuts

Copy link
Copy Markdown
Contributor

Adds a required currency parameter to calculate_total and updates every existing caller and test in this PR. Green on its own.

calculate_total now requires a currency argument; every in-repo caller
and test passes it, so this PR is green on its own.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@veripsa-core

veripsa-core Bot commented Jul 17, 2026

Copy link
Copy Markdown

Veripsa — heading to main

✓ You acknowledged this coupling snapshot — branch protection still decides what merges

This PR reserves: orders/pricing.py, tests/test_pricing.py

Land in order. You collide at lines 11–18 of orders/pricing.py — that's the same code, not just the same file. You are queued behind GH-RollNuts. Landing in this order means you rebase onto their change once — not redo work after both land out of order. When the change ahead lands or withdraws, your reservation advances; if it withdraws, this clears.

Overlapping PRs — 2 open PRs touch this same area. Suggested order to land them (most foundational first, so the others only revise once):

  1. GH-RollNuts BR-collide-a
  2. GH-RollNuts PR-7 ← this PR

Veripsa records what is heading to main and who reserved what — it does not assert correctness. Advisory by default; your branch-protection policy decides what blocks.

✓ Acknowledged — you recorded that you saw this coupling snapshot. Someone added the veripsa-ack label, so Veripsa recorded that you saw this specific coupling and chose to proceed deliberately. This is NOT an approval, a pardon, or a sign-off — Veripsa does not assert the change is correct, and adding the label only records your acknowledgement; whether the PR can merge is decided by your branch-protection policy and reviewers, not by Veripsa. If the coupling changes (a different overlapping PR or files), Veripsa will pause again until you re-acknowledge the new snapshot. (Records-not-correctness — Veripsa records the acknowledgement; it never blocks by itself and it never approves by itself.)

@RollNuts RollNuts added the veripsa-ack Acknowledge the current Veripsa coupling snapshot label Jul 17, 2026
@RollNuts

Copy link
Copy Markdown
Contributor Author

Closing — superseded by the fresh canonical collision pair #13 / #14 (2026-07-20)

This PR touches orders/pricing.py, the same file the fresh canonical demo pair (#13 Agent A / #14 Agent B) collides on. Left open, its active same-path reservation would mix into the fresh pair's landing-order evaluation, muddying a clean two-PR demo. Closing to remove it from active demo traffic.

Historical evidence preserved (not deleted): this PR, its files (orders/pricing.py, tests/test_pricing.py), and its Veripsa output — Veripsa — Acknowledged (neutral) — remain in-thread: #7 (comment)

The canonical current demo is the two-PR pair #13#14 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

veripsa-ack Acknowledge the current Veripsa coupling snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant