Repository navigation
feat(agent): cancel active turns with Escape - #45
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An active turn could only be stopped by quitting the app. Escape now stops the turn and keeps the TUI open for a follow-up request.
Cancellation closes the provider stream, dismisses pending approval, and terminates and reaps shell command process groups. The UI stays busy until cleanup finishes. Ctrl+C uses the same cleanup before exiting.
File changes already in progress finish before cancellation completes. Completed changes remain in place. History retains partial assistant text, completed results, and matching cancellation results for unstarted calls. An incomplete model tool request cannot execute.
Update the status hints, /help, README, and command documentation. Existing model-selector Escape behavior and N/Enter tool denial remain available. No dependencies were added.
Validation:
Cloud provider calls and macOS/Windows behavior were not tested locally. Provider stream cancellation is covered with native and JSON fallback test providers. In-progress file mutations deliberately finish instead of being dropped mid-write.