docs(caveats): describe shipped caveat wiring, not "next step" - #60
Merged
Conversation
The caveats.rs module doc claimed that wiring caveats into `AgentMetadata` and enforcing `child ⊑ parent` "is the next step." That is stale: both the wiring and the enforcement have shipped and are property-tested. On the crate's most authoritative source of truth — the module doc of the type that defines the authority lattice — this drift made an enforced security property read as aspirational. Rewrite the paragraph to describe the shipped state: - caveats are part of the signed cert payload in `AgentMetadata` - attenuation is enforced at two independent points: `AgentKey::delegate` (mint time, refuses amplifying children with `MeshError::CaveatAmplification`) and `CertChain::verify` (verify time, structural re-check at every delegated link — a forged chain is rejected even when each signature is valid) - the genuine forward reference (OS-level enforcement: Landlock, uid-mapped namespaces) and the newt-agent design-doc pointer are preserved. Documentation only — no code or test changes. Intra-doc links to `AgentKey::delegate`, `CertChain::verify`, and `MeshError::CaveatAmplification` resolve cleanly. Fixes #41 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
agent-mesh-protocol/src/caveats.rsmodule doc that claimed wiring caveats intoAgentMetadataand enforcingchild ⊑ parent"is the next step." Both have shipped and are property-tested; the old text made an enforced security property read as aspirational.caveatsfield is part of the signed cert payload, and attenuation is enforced at two independent points —AgentKey::delegaterefuses to mint an amplifying child (MeshError::CaveatAmplification), andCertChain::verifyre-checks attenuation at every delegated link, so a forged chain is rejected even when each signature is valid.docs/decisions/agentic_object_capability_security.mdinnewt-agentis kept.AgentKey::delegate,CertChain::verify, andMeshError::CaveatAmplification(allcrate::-qualified, resolve cleanly).Test plan
just checkpasses locally:cargo fmt --all -- --checkclean,cargo clippy --workspace --all-targets -- -D warningsclean (zero warnings), and the fullcargo test --workspacesuite is green.forged_amplifying_chain_fails_verify,delegate_rejects_amplification,multi_level_delegation_attenuates_each_link,tampered_caveats_fails_verify(all inagent-mesh-protocol/src/agent_key.rs).caveats.rs.Out of scope
caveats.rsmodule doc was out of date.Fixes #41