-
Notifications
You must be signed in to change notification settings - Fork 177
Add interactive terminal companions #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d8e0267
Add terminal companions
anandh8x da2768d
Polish interactive terminal companions
anandh8x d0fcb2d
Fix terminal companion edge cases
anandh8x 581f29b
Strengthen terminal companion regression tests
anandh8x 3c784e7
Preserve config layout when selecting pets
anandh8x c26a97d
Handle sparse pet preference layouts
anandh8x 0c4a1f2
fix(terminalpet): reset SGR before erasing a sixel companion
Vasanthdev2004 cbb4a64
fix(tui): ask sixel terminals for their cell size and erase what was …
Vasanthdev2004 d195972
Keep Sixel companions in the reserved dock
anandh8x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,294 @@ | ||
| package config | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "fmt" | ||
| ) | ||
|
|
||
| type jsonObjectSpan struct { | ||
| start int | ||
| end int | ||
| members []jsonMemberSpan | ||
| } | ||
|
|
||
| type jsonMemberSpan struct { | ||
| key string | ||
| leadingStart int | ||
| keyStart int | ||
| valueStart int | ||
| valueEnd int | ||
| commaAfter int | ||
| } | ||
|
|
||
| // setPetPreferenceJSON changes only preferences.pet. It keeps the original | ||
| // bytes for every unrelated member so choosing a companion does not reorder or | ||
| // reformat the user's configuration file. | ||
| func setPetPreferenceJSON(data []byte, pet string) ([]byte, error) { | ||
| rootStart := skipJSONSpace(data, 0) | ||
| root, err := parseJSONObject(data, rootStart) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| preferencesIndex := lastJSONMember(root.members, "preferences") | ||
| if preferencesIndex < 0 { | ||
| if pet == "" { | ||
| return data, nil | ||
| } | ||
| encodedPet, err := json.Marshal(pet) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("encode pet preference: %w", err) | ||
| } | ||
| return insertJSONMember(data, root, "preferences", petJSONObject(encodedPet)), nil | ||
| } | ||
|
|
||
| preferenceMember := root.members[preferencesIndex] | ||
| preferenceValue := bytes.TrimSpace(data[preferenceMember.valueStart:preferenceMember.valueEnd]) | ||
| if bytes.Equal(preferenceValue, []byte("null")) { | ||
| if pet == "" { | ||
| if lastJSONMember(root.members[:preferencesIndex], "preferences") >= 0 { | ||
| return data, nil | ||
| } | ||
| return removeJSONMember(data, root, preferencesIndex), nil | ||
| } | ||
| encodedPet, err := json.Marshal(pet) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("encode pet preference: %w", err) | ||
| } | ||
| return replaceJSONRange(data, preferenceMember.valueStart, preferenceMember.valueEnd, petJSONObject(encodedPet)), nil | ||
| } | ||
| preferences, err := parseJSONObject(data, preferenceMember.valueStart) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("preferences must be a JSON object: %w", err) | ||
| } | ||
| petIndex := lastJSONMember(preferences.members, "pet") | ||
| if pet != "" { | ||
| encodedPet, err := json.Marshal(pet) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("encode pet preference: %w", err) | ||
| } | ||
| if petIndex >= 0 { | ||
| member := preferences.members[petIndex] | ||
| return replaceJSONRange(data, member.valueStart, member.valueEnd, encodedPet), nil | ||
| } | ||
| return insertJSONMember(data, preferences, "pet", encodedPet), nil | ||
| } | ||
|
|
||
| for petIndex >= 0 { | ||
| data = removeJSONMember(data, preferences, petIndex) | ||
| root, err = parseJSONObject(data, rootStart) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| preferencesIndex = lastJSONMember(root.members, "preferences") | ||
| if preferencesIndex < 0 { | ||
| return data, nil | ||
| } | ||
| preferenceMember = root.members[preferencesIndex] | ||
| preferences, err = parseJSONObject(data, preferenceMember.valueStart) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| petIndex = lastJSONMember(preferences.members, "pet") | ||
| } | ||
| if len(preferences.members) == 0 { | ||
| if lastJSONMember(root.members[:preferencesIndex], "preferences") >= 0 { | ||
| return data, nil | ||
| } | ||
| return removeJSONMember(data, root, preferencesIndex), nil | ||
| } | ||
| return data, nil | ||
| } | ||
|
|
||
| func parseJSONObject(data []byte, start int) (jsonObjectSpan, error) { | ||
| if start < 0 || start >= len(data) || data[start] != '{' { | ||
| return jsonObjectSpan{}, fmt.Errorf("expected JSON object") | ||
| } | ||
| object := jsonObjectSpan{start: start} | ||
| leadingStart := start + 1 | ||
| for { | ||
| i := skipJSONSpace(data, leadingStart) | ||
| if i >= len(data) { | ||
| return jsonObjectSpan{}, fmt.Errorf("unterminated JSON object") | ||
| } | ||
| if data[i] == '}' { | ||
| object.end = i | ||
| return object, nil | ||
| } | ||
| if data[i] != '"' { | ||
| return jsonObjectSpan{}, fmt.Errorf("expected JSON object key") | ||
| } | ||
| keyStart := i | ||
| keyEnd, err := scanJSONString(data, i) | ||
| if err != nil { | ||
| return jsonObjectSpan{}, err | ||
| } | ||
| var key string | ||
| if err := json.Unmarshal(data[keyStart:keyEnd], &key); err != nil { | ||
| return jsonObjectSpan{}, err | ||
| } | ||
| i = skipJSONSpace(data, keyEnd) | ||
| if i >= len(data) || data[i] != ':' { | ||
| return jsonObjectSpan{}, fmt.Errorf("expected colon after JSON object key") | ||
| } | ||
| valueStart := skipJSONSpace(data, i+1) | ||
| valueEnd, err := scanJSONValue(data, valueStart) | ||
| if err != nil { | ||
| return jsonObjectSpan{}, err | ||
| } | ||
| i = skipJSONSpace(data, valueEnd) | ||
| member := jsonMemberSpan{ | ||
| key: key, | ||
| leadingStart: leadingStart, | ||
| keyStart: keyStart, | ||
| valueStart: valueStart, | ||
| valueEnd: valueEnd, | ||
| commaAfter: -1, | ||
| } | ||
| if i < len(data) && data[i] == ',' { | ||
| member.commaAfter = i | ||
| object.members = append(object.members, member) | ||
| leadingStart = i + 1 | ||
| continue | ||
| } | ||
| if i >= len(data) || data[i] != '}' { | ||
| return jsonObjectSpan{}, fmt.Errorf("expected comma or end of JSON object") | ||
| } | ||
| object.members = append(object.members, member) | ||
| object.end = i | ||
| return object, nil | ||
| } | ||
| } | ||
|
|
||
| func scanJSONString(data []byte, start int) (int, error) { | ||
| for i := start + 1; i < len(data); i++ { | ||
| switch data[i] { | ||
| case '\\': | ||
| i++ | ||
| case '"': | ||
| return i + 1, nil | ||
| } | ||
| } | ||
| return 0, fmt.Errorf("unterminated JSON string") | ||
| } | ||
|
|
||
| func scanJSONValue(data []byte, start int) (int, error) { | ||
| if start >= len(data) { | ||
| return 0, fmt.Errorf("missing JSON value") | ||
| } | ||
| if data[start] == '"' { | ||
| return scanJSONString(data, start) | ||
| } | ||
| if data[start] == '{' || data[start] == '[' { | ||
| stack := []byte{data[start]} | ||
| for i := start + 1; i < len(data); i++ { | ||
| if data[i] == '"' { | ||
| end, err := scanJSONString(data, i) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| i = end - 1 | ||
| continue | ||
| } | ||
| switch data[i] { | ||
| case '{', '[': | ||
| stack = append(stack, data[i]) | ||
| case '}', ']': | ||
| open := stack[len(stack)-1] | ||
| if (open == '{' && data[i] != '}') || (open == '[' && data[i] != ']') { | ||
| return 0, fmt.Errorf("mismatched JSON delimiter") | ||
| } | ||
| stack = stack[:len(stack)-1] | ||
| if len(stack) == 0 { | ||
| return i + 1, nil | ||
| } | ||
| } | ||
| } | ||
| return 0, fmt.Errorf("unterminated JSON value") | ||
| } | ||
| for i := start; i < len(data); i++ { | ||
| switch data[i] { | ||
| case ',', '}', ']', ' ', '\t', '\r', '\n': | ||
| if i == start { | ||
| return 0, fmt.Errorf("missing JSON value") | ||
| } | ||
| return i, nil | ||
| } | ||
| } | ||
| return len(data), nil | ||
| } | ||
|
|
||
| func skipJSONSpace(data []byte, start int) int { | ||
| for start < len(data) { | ||
| switch data[start] { | ||
| case ' ', '\t', '\r', '\n': | ||
| start++ | ||
| default: | ||
| return start | ||
| } | ||
| } | ||
| return start | ||
| } | ||
|
|
||
| func lastJSONMember(members []jsonMemberSpan, key string) int { | ||
| for i := len(members) - 1; i >= 0; i-- { | ||
| if members[i].key == key { | ||
| return i | ||
| } | ||
| } | ||
| return -1 | ||
| } | ||
|
|
||
| func petJSONObject(encodedPet []byte) []byte { | ||
| result := append([]byte(`{"pet":`), encodedPet...) | ||
| return append(result, '}') | ||
| } | ||
|
|
||
| func replaceJSONRange(data []byte, start, end int, replacement []byte) []byte { | ||
| result := make([]byte, 0, len(data)-(end-start)+len(replacement)) | ||
| result = append(result, data[:start]...) | ||
| result = append(result, replacement...) | ||
| return append(result, data[end:]...) | ||
| } | ||
|
|
||
| func removeJSONMember(data []byte, object jsonObjectSpan, index int) []byte { | ||
| member := object.members[index] | ||
| start, end := member.leadingStart, member.valueEnd | ||
| if member.commaAfter >= 0 { | ||
| end = member.commaAfter + 1 | ||
| } else if index > 0 { | ||
| start = object.members[index-1].commaAfter | ||
| } | ||
| return replaceJSONRange(data, start, end, nil) | ||
| } | ||
|
|
||
| func insertJSONMember(data []byte, object jsonObjectSpan, key string, value []byte) []byte { | ||
| encodedKey, _ := json.Marshal(key) | ||
| entry := append(append(encodedKey, ':', ' '), value...) | ||
| if len(object.members) == 0 { | ||
| interior := data[object.start+1 : object.end] | ||
| if newline := bytes.LastIndexByte(interior, '\n'); newline >= 0 { | ||
| closingIndent := interior[newline+1:] | ||
| indentUnit := []byte(" ") | ||
| if bytes.Contains(closingIndent, []byte("\t")) { | ||
| indentUnit = []byte("\t") | ||
| } | ||
| lineBreak := []byte("\n") | ||
| if newline > 0 && interior[newline-1] == '\r' { | ||
| lineBreak = []byte("\r\n") | ||
| } | ||
| insert := append(append(append(lineBreak, closingIndent...), indentUnit...), entry...) | ||
| return replaceJSONRange(data, object.start+1, object.start+1, insert) | ||
| } | ||
| return replaceJSONRange(data, object.end, object.end, entry) | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
| last := object.members[len(object.members)-1] | ||
| separator := []byte(", ") | ||
| if bytes.Contains(data[last.valueEnd:object.end], []byte("\n")) { | ||
| lineStart := bytes.LastIndexByte(data[:last.keyStart], '\n') + 1 | ||
| indent := data[lineStart:last.keyStart] | ||
| separator = append([]byte(",\n"), indent...) | ||
| } | ||
| insert := append(separator, entry...) | ||
| return replaceJSONRange(data, last.valueEnd, last.valueEnd, insert) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.