Added Callback when IOS video closed and Fixed Android YouTube Bug. - #25
Open
JonSmart wants to merge 43 commits into
Open
Added Callback when IOS video closed and Fixed Android YouTube Bug.#25JonSmart wants to merge 43 commits into
JonSmart wants to merge 43 commits into
Conversation
For newer android versions (5+), it will use the YouTube API player.
…the Video is finished.
Changing android:screenOrientation from "landscape" to "unspecified" (default). http://developer.android.com/guide/topics/manifest/activity-element.html
# Conflicts: # plugin.xml
…m/p/gdata-issues/issues/detail?id=8244. The app will however now load the YouTube Player on the device leaving your app, which may not be intended...
… having a value in the platform code.
…s/issues/detail?id=8244 and https://code.google.com/p/gdata-issues/issues/detail?id=8248. Checks for YouTube App Version. NOTE: If this is fixed in the next version then change this to be == not >=
…ion was installed.
…ideo finishes like iOS.
|
@JonSmart could you please describe how to use the callback functions ? |
Author
|
@juergengunz I will aim to update the documentation. But in the mean time here is an example of how I have used it: |
Author
|
If you want this to work on Android, you may need to use the latest version of my branch, I will look to add another pull request to this Repository once I have performed some tidying and testing. |
|
@JonSmart thanks! sounds cool. looking forward to it. |
Added package.json for compatibility with npm
fix headlines
|
@Glitchbone why don't you merge it ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a callback in JS, when the IOS video player finishes, this was useful for me to be able to handle some rotation logic.
I also had issues with new YouTube videos not playing, so have merged with some other contributors D0cz and trakout, and added a further fix based on:
https://code.google.com/p/gdata-issues/issues/detail?id=8244