fix: prevent MixinTargetAlreadyLoadedException on startup#8
Open
dudematthew wants to merge 1 commit into
Open
Conversation
AutoConfigAccess and MarshallerImplMixin target classes from cloth-config (AutoConfig, MarshallerImpl) that get loaded too early by other mods during preLaunch causing a hard crash. - Replace AutoConfigAccess mixin with reflection-based AutoConfigHelper - Remove MarshallerImplMixin (was adding '// client only' comments to JSON configs, cosmetic only — sync logic unaffected) - Remove LibzMixinPlugin from mixin config (was all no-ops)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: crash on startup with certain mod combinations
Fixes issue #2.
What was happening
LibZ has two mixins targeting classes inside cloth-config (
AutoConfigandMarshallerImpl). Several mods load these classes during theirpreLaunchentrypoint. By the time LibZ's mixin subsystem tries to prepare those mixins, the targets are already in memory and can't be transformed anymore, resulting in a hardMixinTargetAlreadyLoadedExceptioncrash.What did I change
AutoConfigAccess- replaced with a plain reflection helper. The mixin only ever read the privateholdersfield fromAutoConfig, which reflection handles identically since it's only called at runtime.MarshallerImplMixin- removed. It was adding// client onlycomments to JSON config files, which is cosmetic. The actual client-only sync logic inEventInitandLibzClientPacketis unaffected. Worth noting that a proper replacement would be post-processing the JSON after serialization rather than hooking intoMarshallerImpldirectly - flagging in case you want to revisit.LibzMixinPlugin- removed from the mixin config. All its methods were no-ops.Tested with
Full mod stack