Skip to content

Conversation

@syntrydy
Copy link
Contributor

@syntrydy syntrydy commented Jan 12, 2026

#2571
Closes #2571

Summary by CodeRabbit

Release Notes

  • Removed Features
    • SQL database configuration management removed from the Admin UI. Users can no longer add, edit, or view SQL database configurations.
    • Couchbase database configuration management removed from the Admin UI. Users can no longer view or manage Couchbase database configurations.
    • Associated navigation menu items and configuration screens for SQL and Couchbase database management are no longer available.

✏️ Tip: You can customize this high-level summary in your review settings.

@syntrydy syntrydy self-assigned this Jan 12, 2026
@syntrydy syntrydy requested a review from duttarnab as a code owner January 12, 2026 16:22
@syntrydy syntrydy added comp-admin-ui Component affected by issue or PR comp-docker-admin-ui Component affected by issue or PR labels Jan 12, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

This pull request removes all Couchbase and SQL database configuration pages, components, and related infrastructure from the Admin UI. This includes deleting permission constants, route definitions, React components, hooks, type definitions, and updating plugin metadata to remove associated feature registrations.

Changes

Cohort / File(s) Summary
Permission & Constants Removal
admin-ui/app/utils/PermChecker.ts, admin-ui/app/cedarling/constants/resourceScopes.ts
Removed 6 permission constants (COUCHBASE_READ/WRITE/DELETE, SQL_READ/WRITE/DELETE) from PermChecker exports and removed SQL permissions from resource scope declarations
Route Navigation Removal
admin-ui/app/helpers/navigation.ts
Removed 5 route definitions: SERVICES_COUCHBASE, SQL_LIST, SQL_ADD, SQL_EDIT, SQL_EDIT_TEMPLATE
Couchbase Components & Page
admin-ui/plugins/services/Components/Configuration/CouchbaseItem.tsx, admin-ui/plugins/services/Components/Configuration/CouchbasePage.tsx
Deleted entire Couchbase configuration item component and page component (combined 349 lines)
SQL Configuration Pages
admin-ui/plugins/services/Components/Configuration/SqlAddPage.tsx, admin-ui/plugins/services/Components/Configuration/SqlDetailPage.tsx, admin-ui/plugins/services/Components/Configuration/SqlEditPage.tsx
Deleted three SQL configuration page components (add, detail, edit flows; combined 258 lines)
SQL Form & List Components
admin-ui/plugins/services/Components/Configuration/SqlForm.tsx, admin-ui/plugins/services/Components/Configuration/SqlListPage.tsx
Deleted SQL configuration form component and list page with table, mutations, and detail panel (combined 609 lines)
Supporting Infrastructure
admin-ui/plugins/services/Components/Configuration/atoms/index.ts, admin-ui/plugins/services/Components/Configuration/hooks/index.ts, admin-ui/plugins/services/Components/Configuration/types.ts
Removed currentSqlItemAtom, SQL/Couchbase audit hooks (useSqlAudit, useCouchbaseAudit), and related type interfaces (SqlFormProps, SqlDetailPageProps, CouchbaseItemProps, CouchbaseFormValues)
Plugin Metadata
admin-ui/plugins/services/plugin-metadata.js
Removed imports and route registrations for CouchbasePage, SqlListPage, SqlAddPage, SqlEditPage and associated permissions

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Suggested labels

kind-bug

Suggested reviewers

  • duttarnab
  • moabu
  • faisalsiddique4400

Poem

🐰 Hop hop, away they go!
Couchbase and SQL, no more show,
Routes and hooks now obsolete,
Cleaner code makes my whiskers neat! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Remove Couchbase and SQL related pages from admin UI' accurately describes the main objective of the changeset, which involves removing multiple Couchbase and SQL-related components, pages, routes, and permissions.
Linked Issues check ✅ Passed The PR fully implements the objective from issue #2571 to remove Couchbase and SQL related pages from the admin UI, eliminating all associated components, routes, permissions, and utilities.
Out of Scope Changes check ✅ Passed All changes in the PR are directly scoped to removing Couchbase and SQL-related functionality; no unrelated or out-of-scope modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 566564a and f0f1515.

📒 Files selected for processing (14)
  • admin-ui/app/cedarling/constants/resourceScopes.ts
  • admin-ui/app/helpers/navigation.ts
  • admin-ui/app/utils/PermChecker.ts
  • admin-ui/plugins/services/Components/Configuration/CouchbaseItem.tsx
  • admin-ui/plugins/services/Components/Configuration/CouchbasePage.tsx
  • admin-ui/plugins/services/Components/Configuration/SqlAddPage.tsx
  • admin-ui/plugins/services/Components/Configuration/SqlDetailPage.tsx
  • admin-ui/plugins/services/Components/Configuration/SqlEditPage.tsx
  • admin-ui/plugins/services/Components/Configuration/SqlForm.tsx
  • admin-ui/plugins/services/Components/Configuration/SqlListPage.tsx
  • admin-ui/plugins/services/Components/Configuration/atoms/index.ts
  • admin-ui/plugins/services/Components/Configuration/hooks/index.ts
  • admin-ui/plugins/services/Components/Configuration/types.ts
  • admin-ui/plugins/services/plugin-metadata.js
💤 Files with no reviewable changes (12)
  • admin-ui/app/helpers/navigation.ts
  • admin-ui/app/cedarling/constants/resourceScopes.ts
  • admin-ui/plugins/services/Components/Configuration/SqlAddPage.tsx
  • admin-ui/plugins/services/Components/Configuration/SqlListPage.tsx
  • admin-ui/app/utils/PermChecker.ts
  • admin-ui/plugins/services/Components/Configuration/SqlEditPage.tsx
  • admin-ui/plugins/services/Components/Configuration/CouchbaseItem.tsx
  • admin-ui/plugins/services/Components/Configuration/types.ts
  • admin-ui/plugins/services/plugin-metadata.js
  • admin-ui/plugins/services/Components/Configuration/SqlDetailPage.tsx
  • admin-ui/plugins/services/Components/Configuration/CouchbasePage.tsx
  • admin-ui/plugins/services/Components/Configuration/SqlForm.tsx
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-07T12:55:26.241Z
Learnt from: kdhttps
Repo: GluuFederation/flex PR: 2378
File: admin-ui/plugins/admin/components/Cedarling/CedarlingConfigPage.tsx:93-104
Timestamp: 2025-11-07T12:55:26.241Z
Learning: In the Cedarling configuration feature (admin-ui/plugins/admin/components/Cedarling/CedarlingConfigPage.tsx), the sync role to scopes mappings operation depends on the `auiPolicyStoreUrl`. The backend fetches content from this URL and syncs roles based on the response. Therefore, the audit log for the sync operation should include the `auiPolicyStoreUrl` in its payload to provide proper audit context.

Applied to files:

  • admin-ui/plugins/services/Components/Configuration/hooks/index.ts
📚 Learning: 2026-01-06T13:45:19.278Z
Learnt from: faisalsiddique4400
Repo: GluuFederation/flex PR: 2561
File: admin-ui/plugins/auth-server/components/Configuration/ConfigApiConfiguration/validations.ts:4-101
Timestamp: 2026-01-06T13:45:19.278Z
Learning: In admin-ui/plugins/auth-server/components/Configuration/ConfigApiConfiguration/validations.ts, ensure Yup schema marks fields as nullable when the backend DTOs permit nulls and do not mark them as required. Align frontend validation with backend validation to prevent conflicts when editing existing configurations with null values; apply this pattern consistently to other Admin UI validation files where the backend is the source of truth.

Applied to files:

  • admin-ui/plugins/services/Components/Configuration/hooks/index.ts
  • admin-ui/plugins/services/Components/Configuration/atoms/index.ts
🔇 Additional comments (2)
admin-ui/plugins/services/Components/Configuration/atoms/index.ts (1)

1-4: LGTM! SQL atom correctly removed.

The changes properly remove the SqlConfiguration import and currentSqlItemAtom export. Verification confirms no remaining references to currentSqlItemAtom or SqlConfiguration exist in the codebase, and the remaining LDAP atom is correctly typed.

admin-ui/plugins/services/Components/Configuration/hooks/index.ts (1)

1-129: Clean removal of SQL and Couchbase audit hooks.

The changes align well with the PR objective. All remaining imports are utilized (CREATE, UPDATE, DELETION, PATCH), and the useLdapAudit and useCacheAudit hooks maintain consistent patterns with proper memoization. No remaining references to the removed hooks (useSqlAudit, useCouchbaseAudit) or types (SqlConfiguration, CouchbaseConfiguration) exist in the codebase.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Jan 12, 2026
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-admin-ui Component affected by issue or PR comp-docker-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(admin-ui): Remove Couchbase and SQL related pages from admin UI

4 participants