This repository was archived by the owner on Jan 8, 2022. It is now read-only.
Remove variadic args from the PROC callback types #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
More than likely you are overestimating the amount of manual code that's written here. On top of that it's likely that Zig itself generates other code nowadays for the same thing. Have you tried these changes out in practice? P.S. I'm very sorry about the late reply. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are copied from
lean_and_mean.zigThe main reason for doing this is for i386 builds, where Zig defines
std.os.windows.WINAPIasStdcallrather thanC, and Zig doesn't support variadic args unless the calling convention isC.I completely appreciate there could be a reason I'm missing as to why these are variadic though!