Skip to content

feat: return doubles when quantity dimensions cancel - #10

Merged
ScottishTapWater merged 1 commit into
mainfrom
feat/dimension-cancelling-arithmetic
Oct 23, 2026
Merged

ScottishTapWater merged 1 commit into
mainfrom
feat/dimension-cancelling-arithmetic

Conversation

@ScottishTapWater

Copy link
Copy Markdown
Contributor

Summary

  • Return double when dividing quantities with matching dimensions, using a core generic operator.
  • Generate double-returning multiplication operators when operand dimensions cancel.
  • Carry the resulting scalar through nested expressions and inferred locals for subsequent quantity arithmetic.
  • Avoid generating dimensionless quantity aliases.

Verification

  • Tests written before implementation.
  • All 474 tests pass: 314 core, 159 Roslyn, and 1 packaged-consumer integration test.
  • Build, formatting, and diff checks pass.
  • Independent production and test reviews completed twice, including test ownership and class responsibility checks; no outstanding findings.

@ScottishTapWater
ScottishTapWater merged commit 7ba478d into main Oct 23, 2026
2 checks passed
@ScottishTapWater
ScottishTapWater deleted the feat/dimension-cancelling-arithmetic branch October 23, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant