Repository navigation
fix: build solution before packaging release - #12
Merged
Merged
Conversation
ScottishTapWater
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release packaging failed on a clean checkout because the runtime's pack target tried to restore and build its dependent Roslyn project inside the running MSBuild process. Remove that target: the release script now builds the solution normally, then packages the existing outputs with
dotnet pack --no-build.CI runs this same sequence from a clean checkout before testing. The packaged consumer test also packages its existing build configuration without rebuilding.
Verified from clean outputs: package build and layout check, all 518 tests (including the packaged consumer), formatting, and independent review passed. Local verification used SDK 10.0.113; the repository retains its SDK 10.0.402 pin for CI.