Skip to content

feat: parse English rational number names - #13

Merged
ScottishTapWater merged 2 commits into
mainfrom
feat/english-rational-parser
Oct 24, 2026
Merged

ScottishTapWater merged 2 commits into
mainfrom
feat/english-rational-parser

Conversation

@ScottishTapWater

Copy link
Copy Markdown
Contributor

Summary

  • Add a core English rational parser using typed tokens and left-to-right integer parsing.
  • Support signed integers, named fractions through millionths, and XOverY spellings, with grammar validation and BigInteger arithmetic.
  • Use the parser as a fallback in Rational.TryParse, preserving numeric parsing and number styles. Rational.Parse remains unchanged.
  • Add focused parser tests and Rational parsing regressions; generator discovery is outside this change.

Verification

  • Independent C# production and test reviews completed; the missing agreed grammar regression was added and re-reviewed.
  • Solution build: zero warnings and errors.
  • Full suite: 645 tests passed, including the packaged-consumer integration test.
  • Formatting verification and git diff --check passed.

@ScottishTapWater

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-24T09:28:04.106603Z 4e94c68 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScottishTapWater
ScottishTapWater enabled auto-merge (squash) October 24, 2026 09:46
@ScottishTapWater
ScottishTapWater merged commit 726e822 into main Oct 24, 2026
2 checks passed
@ScottishTapWater
ScottishTapWater deleted the feat/english-rational-parser branch October 24, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant