Repository navigation
feat: discover quantities from canonical type declarations - #21
Merged
ScottishTapWater merged 1 commit intoOct 24, 2026
Merged
Conversation
ScottishTapWater
enabled stacked auto-merge (squash)
October 24, 2026 18:04
stacked auto-merge was automatically disabled
October 24, 2026 18:06
Auto-merge was disabled for another pull request in the stack
ScottishTapWater
added a commit
that referenced
this pull request
Oct 24, 2026
…ty (#22) ## Summary Stack 6 of 6, based on #21. - Discover quantity dimensions from referenced values, including fields, properties, method results and nested collection types. - Generate consumer-local helpers even when no arithmetic or explicit quantity name requests them. - Use the existing type reader and planning pipeline; avoid scanning entire referenced assemblies. - Respect existing aliases, types and namespaces, and defer encoded-type symbol resolution until a possible quantity is found. - Add an ephemeral A/B/C NuGet test: independently build and pack A and B, consume both from C, verify quantity type identity and conversions, and generate further arithmetic in C. ## Verification - Solution build: no warnings or errors. - Core: 471 passed; Roslyn: 436 passed; package integration: 2 passed. - Format verification and `git diff --check` pass. - Independent C# production and test reviews; fixes independently reviewed again. No fixture projects or package artifacts are committed. This completes the six discovery slices; diagnostics and IDE polish remain separate follow-up work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack 5 of 6, based on #20.
Verification
git diff --checkpassed.The next PR adds referenced-assembly discovery and package interoperability coverage.