Skip to content

test: scope discovery coverage and verify result dimensions - #26

Merged
ScottishTapWater merged 1 commit into
feat/discovery-rebindingfrom
test/discovery-coverage
Oct 24, 2026
Merged

ScottishTapWater merged 1 commit into
feat/discovery-rebindingfrom
test/discovery-coverage

Conversation

@ScottishTapWater

Copy link
Copy Markdown
Contributor

Summary

  • Move 14 discovery scenario methods from generator tests into coordinator tests, retaining generator lifecycle and acceptance coverage.
  • Verify concrete result dimensions before converting composition results to SI values.
  • Cover arithmetic over an IEnumerable<LengthCurrent> parameter using foreach.

Stacked on #25 (feat/discovery-rebinding). Only test changes are included.

Verification

  • Independent C# review: no findings.
  • Roslyn suite: 375 passed, 0 failed.
  • Test project build: 0 warnings, 0 errors.
  • Formatting verification and git diff --check passed.

@ScottishTapWater
ScottishTapWater enabled stacked auto-merge (squash) October 24, 2026 18:04
stacked auto-merge was automatically disabled October 24, 2026 18:06

Auto-merge was disabled for another pull request in the stack

@ScottishTapWater
ScottishTapWater merged commit 4516e78 into main Oct 24, 2026
2 checks passed
@ScottishTapWater
ScottishTapWater deleted the test/discovery-coverage branch October 24, 2026 18:07
ScottishTapWater added a commit that referenced this pull request Oct 24, 2026
## Summary

Stacked on #26 (`test/discovery-coverage`).

- Upgrade the pinned SDK to .NET 11 RC2 and the test projects to
net11.0; enable preview language features in compilation fixtures and
package consumers.
- Update the existing Microsoft.Build reference to the version required
by the integration-test project builder on .NET 11.
- Add discovery coverage for generic interfaces and constraints,
patterns, synchronous/asynchronous iterators, and union cases.
- Cover out variables, mutable/readonly ref returns, Span/ReadOnlySpan
indexing, property/list patterns, and custom deconstruction.
- Check concrete result dimensions and runtime values. Keep
nullable-operation work for a follow-up.

Runtime and generator packages retain their netstandard2.0 targets. CI
already installs the SDK pinned by global.json.

## Verification

- Solution build: zero warnings/errors.
- Full suite: 868 passed (471 core, 395 Roslyn, 2 package integration).
- Corrected the union rejection test's generated-source hint during
review; its focused rerun passed after rebuilding.
- Formatting verification and git diff --check passed.
- Independent C# behaviour/adequacy and test style reviews completed
with no remaining findings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant