Skip to content

fix: discover division with nullable scalar numerators - #29

Merged
ScottishTapWater merged 1 commit into
feat/nullable-discoveryfrom
fix/nullable-scalar-discovery
Oct 24, 2026
Merged

ScottishTapWater merged 1 commit into
feat/nullable-discoveryfrom
fix/nullable-scalar-discovery

Conversation

@ScottishTapWater

Copy link
Copy Markdown
Contributor

Summary

Stacked on #28 (feat/nullable-discovery).

  • Recognise nullable numeric scalar numerators when discovering scalar/quantity division.
  • Reuse the existing reciprocal operator and C# nullable lifting.
  • Preserve the existing implicit numeric conversion restrictions, including rejection of nullable decimal.
  • Add discovery and execution regressions covering nullable/non-nullable divisors and null propagation.

Verification

  • Before the fix: 12 new regression cases failed; the nullable decimal rejection case passed.
  • After the fix: all 13 new cases passed; both affected test classes passed (144/144).
  • Build: zero warnings/errors.
  • Formatting verification and git diff --check passed.
  • Independent C# review: no findings.

@ScottishTapWater
ScottishTapWater enabled stacked auto-merge (squash) October 24, 2026 18:04
@ScottishTapWater
ScottishTapWater disabled stacked auto-merge October 24, 2026 18:06
@ScottishTapWater
ScottishTapWater merged commit 9ce1f55 into main Oct 24, 2026
2 checks passed
@ScottishTapWater
ScottishTapWater deleted the fix/nullable-scalar-discovery branch October 24, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant