Repository navigation
feat: explain dimensional mismatches with diagnostics - #32
Merged
Merged
Conversation
ScottishTapWater
added a commit
that referenced
this pull request
Oct 24, 2026
## Stack Second of three; based on #32 (`feat/dimension-diagnostics`). ## Summary - DQ0003 suggests readable quantity aliases, DQ0004 identifies noncanonical encodings, and DQ0005 identifies invalid closed encodings. - Allow deliberate aliases and open generics; ignore unresolved types while editing. - Add a separate IDE code-fix assembly using the approved Workspaces/Composition dependencies. - Apply aliases only when they bind to the same type; preserve trivia and nullable syntax, and withhold fixes inside nameof. - Discover raw generic quantity declarations so non-catalogued aliases are available for replacement. - Extend package checks and treat analyzer-load/generator-crash warnings as errors in packaged-consumer tests. ## Verification - Tests written before implementation, including real CodeAction application and recompilation of fixed source. - Full suite: 981 passed before final nameof guard; all 30 focused encoding/code-fix/discovery checks passed after that guard. - Independent production and test reviews, plus review of the safety fix, passed. - Clean build, formatting verification, Release pack/layout check and both packaged-consumer tests passed. - IDE code actions tested through Roslyn AdhocWorkspace; not manually exercised in Rider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of three analyser PRs.
Verification
git diff --checkclean.