Repository navigation
fix: remove affine conversions and add Rankine - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove Fahrenheit helpers and the offset-based conversion API. A temperature difference currently shares the same
Temperaturetype as a temperature reading, so an affine accessor can silently apply an absolute offset to a difference. We will revisit affine scales as a separate feature after settling their value semantics.Add Rankine as a scale-only Imperial temperature conversion (
K = °R × 5/9). Update the package smoke test and README accordingly.This deliberately removes the public
UnitConversionAttributeAPI before it has external consumers.Verification
dotnet format --verify-no-changes --no-restorepassed for changed C# files.The branch was rebased onto current
mainafter the extension stack merged. Its resulting tree is identical to the verified local tree.