Repository navigation
feat: add affine temperature conversions and explicit deltas - #44
Merged
Merged
Conversation
ScottishTapWater
changed the title
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ScottishTapWater
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temperaturealias toAbsoluteTemperaturewhile keeping the mathematical temperature dimension and compound names unchanged.Delta<TQuantity>andQuantity<TDimension>.AsDelta()to explicitly reinterpret the stored SI magnitude as a difference.[AffineUnit]; generated delta accessors use scale without offsets, including for Kelvin and Rankine.Validation
dotnet test src/DimensionalQuantities.slnx --no-restore -v:q— 1,030 passed.dotnet format src/DimensionalQuantities.slnx --verify-no-changes --no-restore -v:q— passed.Delta<AbsoluteTemperature>and a consumer referencing Metric and Imperial together.API note
Temperatureis no longer generated as a standalone alias. Callers should useAbsoluteTemperature..AsDelta()preserves the current SI magnitude; it does not infer whether subtraction occurred.