Add DynamicGroup support to goby_clang_tool viz#360
Draft
Conversation
Co-authored-by: tsaubergine <732276+tsaubergine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add dynamic groups to goby_clang_tool viz
Add DynamicGroup support to goby_clang_tool viz
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goby_clang_tool -genonly matched staticpublish/subscribecalls (compile-timeconstexpr Grouptemplate args), silently ignoringpublish_dynamic/subscribe_dynamiccalls that useDynamicGroup. This meant any application using runtime groups was invisible in the generated diagrams.Changes
generate.cpp— newpubsub_dynamic_matcher()publish_dynamic<Data, scheme>(data, DynamicGroup("str"))andsubscribe_dynamic<Data, scheme>(cb, DynamicGroup("str"))DynamicGroup("literal")and variables initialized from one; silently skips truly runtime-computed groups[0]=Data,[1]=schemevs[0]=group,[1]=Data,[2]=schemeis_dynamicset via exact method name checkpubsub_entry.h—is_dynamicfieldbool is_dynamic{false}toPubSubEntryis_dynamic: trueemitted/parsed only when set)bool dynamic = falsedefault arg (ABI-safe for existing callers)visualize.cpp— visual distinctiondynamic_style = "dashed"for dynamic group edges (complements existingsolid/bold/tapered/dotted)connection_with_label_final()applies dashed style and appends[dynamic]to the hover tooltip whenis_dynamicis setis_dynamicpropagated throughconnection_with_label(),disconnected_publication(), anddisconnected_subscription()via thePubSubEntryobjects — no signature changes to call sitesOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.