Skip to content

Update dependencies and fix some code#87

Draft
Diamondman121314 wants to merge 7 commits into
masterfrom
dependency-update
Draft

Update dependencies and fix some code#87
Diamondman121314 wants to merge 7 commits into
masterfrom
dependency-update

Conversation

@Diamondman121314

@Diamondman121314 Diamondman121314 commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator

Keepin' up with the times with up-to-date dependencies!

Updated:
jersey-bom: 2.9.1 -> 3.0.3
JUnit: 4.9 -> 4.13.2
JDA: 4.2.0_214 -> 4.3.0_339
commons-io: 2.5 -> 2.11.0
gson: 2.8.1 -> 2.8.8
commons-lang: "LATEST" -> 3.12.0 (Maven apparently doesn't like this, at least won't in the future)
Twitter4J: 4.0.6 -> 4.0.7
weebJava: 2.2.0_27 -> 3.0.1_4
RethinkDB: 2.3.3 -> 2.4.0
JDA-Utilities: 3.0.2 -> 3.0.5
logback-classic: 1.2.1 -> 1.2.6
jsoup: 1.10.1 -> 1.14.3
maven-assembly-plugin: 2.4.1 -> 3.3.0

@Godson777

Godson777 commented Sep 15, 2021

Copy link
Copy Markdown
Owner

Y'know, I would've preferred you specify everything you updated rather than just "I updated dependencies", but oh well I guess

edit: nvm you listed everything u updated and now i look dumb

@Godson777 Godson777 self-requested a review September 15, 2021 19:15
@Godson777 Godson777 self-assigned this Sep 15, 2021
@Godson777 Godson777 added the dependencies Pull requests that update a dependency file label Sep 15, 2021

@Godson777 Godson777 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have these changes been tested on your end btw, everything looks fine otherwise

@Diamondman121314

Diamondman121314 commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator Author

I have not tested the changes. The minor dependencies updates I don't think will cause any issues, like commons-*, gson, etc. I also considered updating to the JDA-Utilities fork, Chewtilities as it supports newer features, but I figured there would be no point.

My only two possible concerns would be weebJava and RethinkDB. I made sure to look at weebJava before updating and I think what I did would work. I don't see why it wouldn't work though. I also believe that RethinkDB should be fine, as the breaking update for that was 2.4.1 as far as I'm aware. Apart from that, everything should be good!

@Godson777

Copy link
Copy Markdown
Owner

I'm tempted to test the weeb commands at the very least because knowing my luck something will break. So this pull request may have to sit for a lil while until I find the time to do so

@Diamondman121314 Diamondman121314 changed the title Update dependencies Update dependencies and fix some code Oct 30, 2021
@Diamondman121314 Diamondman121314 marked this pull request as draft January 11, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants