Skip to content

Dt corentin - #80

Closed
MinaroliCorentin wants to merge 23 commits into
GoelandProver:masterfrom
MinaroliCorentin:dt-Corentin
Closed

Dt corentin#80
MinaroliCorentin wants to merge 23 commits into
GoelandProver:masterfrom
MinaroliCorentin:dt-Corentin

Conversation

@MinaroliCorentin

Copy link
Copy Markdown

Final Commit.

Unify and UnifyTerm works pretty good.
Unify2 and UnifyTerm2 Workish, fail on some TPTP and the code is grabage. It's probably better to delete all V2 fonction and start from scratch.

@github-actions github-actions Bot added the needs:ci Needs a CI run before merging label Jun 19, 2026
@jrosain

jrosain commented Jun 22, 2026

Copy link
Copy Markdown
Member

Hi, thanks for your interest in contributing to Goeland.

Could you please follow the points 3 to 9 of the contributor's guide?

In fact, most of these points can be answered by filling the pull request template that should have been displayed when you created it. You can simply copy/paste the content of the file and fill out the relevant parts in the PR description.

@MinaroliCorentin

Copy link
Copy Markdown
Author

Hi,
I noticed some bugs and minor problem after this P.R.
Considering that, i'll close the P.R and make another one. However, i'm finishing my bachelor degree, so it may take some time ( ~2weeks).
I take notes of your comment and will follow the guide next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:ci Needs a CI run before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants