feat: implementation of discrimination trees - #81
Open
MinaroliCorentin wants to merge 23 commits into
Open
Conversation
… + Test for all functions
Working on Type Unification
Unify works again. To Do : Find Why UnifyTerm Bug. Fix all the v2. Try the different tptp test
Unify and UnifyTerm works pretty good. Unify2 and UnifyTerm2 Workish, fail on some TPTP and the code is grabage. It's probably better to delete all V2 fonction and start from scratch.
…tf1_basic_thm-2.p doesn't works anymore
jrosain
self-requested a review
July 26, 2026 10:36
github-actions
Bot
removed
needs:ci
jrosain
requested changes
Jul 29, 2026
Member
There was a problem hiding this comment.
After running locally, I believe that the failure of the test-suite is probably to basics/equality-blowup.p.
This is one thing that should be fixed.
Moreover, I think that @jcailler should submit ccddd14 as a separate PR before I can review this one.
jrosain
added
kind:enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the possibility to store terms using a discriminationTree rather than the original codeTree. The discriminationTree est available using the -dt option in the terminal. 2 options are possibles. The "basic" one try to check if a branch is suitable for unification and the second option, available with "-ep" option, use early-pruning. Both call the Robinson algorithm already available in the master branch. The DTree is able support Typed Term by storing them after the predicate :
Root == Predicat, Then optionnal Types, then terms.
The DTree use goroutines when function Unify is called to looking every branch ( 1 branch == 1 goroutine ) in order to retrieve all the potential unifiable branch ( RetrieveUnifiables functions ).
PR Dependencies
Test-suite update
Devtools/make test-suite works perfectly for Dtree, Dtree with option -ep but also with the original CodeTree.
Notes.
The discirminationTree equality module might note works well because it's not included in this project / branch.