Making SVGView XP compliant #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement complete CGAffineTransform struct for environments without CoreGraphics - Move identity property to shared extension for cross-platform consistency - Make SVGStroke and SVGPath initializers more flexible with optional parameters - Improve code readability with multiline parameter formatting
- Implement SVGBezierPath class for cross-platform path handling - Restructure CoreGraphicsPolyfills with WASI/Linux specific implementations - Add platform-specific conditionals to SVGPathReader - Enhance CGAffineTransform and CGPath implementations - Remove unused UI extensions
- Add proper imports for WASI (WASILibc) and Linux (Glibc) - Implement MBezierPath with full functionality for WASI/Linux platforms - Add missing math functions for non-Apple platforms - Fix mutable path variable in SVG path reader - Simplify CGAffineTransform serialization
khoi
commented
May 15, 2025
| elements.append(contentsOf: newElements) | ||
| } | ||
|
|
||
| public mutating func addEllipse(in rect: CGRect) { |
Collaborator
Author
There was a problem hiding this comment.
this file contains majority of the changes.
- Part of ongoing cross-platform compatibility effort - Eliminates iOS/macOS dependent SVGBezierPath class - Related to graphics polyfill refactoring from previous commits
Collaborator
Author
|
Superseded by #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reviewers: Search for
#if os(WASI), that should indicate the codes where I add new thingsTests are failing if u run on macOS even on the original repo, it's not a priority to fix