Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces native build and Helm support while updating type definitions and configurations. Key changes include:
- Addition of license headers and adjustments in Kubernetes YAML configuration files.
- Updates to TypeScript types (e.g. renaming “containerName” to “name” and changing container types in LogSourceStatus) and modifications to default configurations.
- Extensive additions of new modules for native Helm and native build support with corresponding tests and schema updates.
Reviewed Changes
Copilot reviewed 80 out of 81 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sysops/tilt/*.yaml | Added license headers. |
| src/shared/types.ts | Updated ContainerInfo and LogSourceStatus types. |
| src/shared/config.ts | Changed default value for APP_HOST. |
| src/server/models/Deploy.ts | Added new “manifest” field. |
| src/server/lib/yamlSchemas/schema_1_0_0/*.ts | Modified schema settings to allow additional properties. |
| src/server/lib/nativeHelm/* | Introduced native Helm support with extensive new functionality and tests. |
| src/server/lib/nativeBuild/* | Added native build support modules and tests. |
| Other service and test files | Updated logging, dependency handling, and refined API responses. |
Comments suppressed due to low confidence (5)
src/shared/types.ts:37
- Renaming 'containerName' to 'name' in ContainerInfo improves consistency; please verify that all references to this type are updated accordingly.
name: string;
src/server/models/Deploy.ts:68
- The addition of the 'manifest' field implies that downstream modules or database migrations may need updates; please confirm that all necessary migration steps or adjustments have been accounted for.
manifest: string;
src/server/lib/yamlSchemas/schema_1_0_0/schema_1_0_0.ts:120
- Changing 'additionalProperties' to true for the Helm schema increases flexibility; ensure that this behavior is documented and that consuming code correctly handles extra properties.
additionalProperties: true,
src/server/lib/nativeHelm/utils.ts:240
- [nitpick] Consider adding inline comments within 'constructHelmCommand' detailing how the command is assembled and how custom values and default arguments are merged to improve readability for future maintainers.
} else {
src/shared/config.ts:109
- [nitpick] Ensure that shifting the default APP_HOST to 'http://localhost:5001' is aligned with your environment expectations and will not inadvertently affect production workflows.
export const APP_HOST = getServerRuntimeConfig('APP_HOST', 'http://localhost:5001');
vigneshrajsb
approved these changes
Jun 27, 2025
Contributor
vigneshrajsb
left a comment
There was a problem hiding this comment.
thank you for these!! super useful updates.
let's merge and work on rough edges if identified.
happy to support anything needed as fast follow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iniDockerImagetemplated env vardeploymentDependsOnwith mix of deploy types, helm->github->helm ...etcdetailsandeventsview in the deploy and build logs pages