Skip to content

Native build and helm support#16

Merged
vmelikyan merged 8 commits intomainfrom
native-build-and-helm
Jun 27, 2025
Merged

Native build and helm support#16
vmelikyan merged 8 commits intomainfrom
native-build-and-helm

Conversation

@vmelikyan
Copy link
Copy Markdown
Contributor

@vmelikyan vmelikyan commented Jun 27, 2025

  • support for local, remote and public charts
  • support for https:// and oci:// charts (currently only public oci)
  • runs helm release in the environment's namespace as a job
  • improves native builds to run in environment's namespace as a job
  • Better UI for inspecting build and deploy logs
  • Update PR comment to persist service table view with build and deploy log links
  • many other QOL improvements
  • Improved log pages
  • support for iniDockerImage templated env var
  • applies kubernetes (github type) deployments via jobs
  • honors deploymentDependsOn with mix of deploy types, helm->github->helm ...etc
  • add details and events view in the deploy and build logs pages
  • view helm deploy values and generated manifest in the deployLogs page
  • "cloud native" logs for build and deploy

@vmelikyan vmelikyan requested a review from a team as a code owner June 27, 2025 21:28
@vigneshrajsb vigneshrajsb requested a review from Copilot June 27, 2025 21:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces native build and Helm support while updating type definitions and configurations. Key changes include:

  • Addition of license headers and adjustments in Kubernetes YAML configuration files.
  • Updates to TypeScript types (e.g. renaming “containerName” to “name” and changing container types in LogSourceStatus) and modifications to default configurations.
  • Extensive additions of new modules for native Helm and native build support with corresponding tests and schema updates.

Reviewed Changes

Copilot reviewed 80 out of 81 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sysops/tilt/*.yaml Added license headers.
src/shared/types.ts Updated ContainerInfo and LogSourceStatus types.
src/shared/config.ts Changed default value for APP_HOST.
src/server/models/Deploy.ts Added new “manifest” field.
src/server/lib/yamlSchemas/schema_1_0_0/*.ts Modified schema settings to allow additional properties.
src/server/lib/nativeHelm/* Introduced native Helm support with extensive new functionality and tests.
src/server/lib/nativeBuild/* Added native build support modules and tests.
Other service and test files Updated logging, dependency handling, and refined API responses.
Comments suppressed due to low confidence (5)

src/shared/types.ts:37

  • Renaming 'containerName' to 'name' in ContainerInfo improves consistency; please verify that all references to this type are updated accordingly.
  name: string;

src/server/models/Deploy.ts:68

  • The addition of the 'manifest' field implies that downstream modules or database migrations may need updates; please confirm that all necessary migration steps or adjustments have been accounted for.
  manifest: string;

src/server/lib/yamlSchemas/schema_1_0_0/schema_1_0_0.ts:120

  • Changing 'additionalProperties' to true for the Helm schema increases flexibility; ensure that this behavior is documented and that consuming code correctly handles extra properties.
            additionalProperties: true,

src/server/lib/nativeHelm/utils.ts:240

  • [nitpick] Consider adding inline comments within 'constructHelmCommand' detailing how the command is assembled and how custom values and default arguments are merged to improve readability for future maintainers.
    } else {

src/shared/config.ts:109

  • [nitpick] Ensure that shifting the default APP_HOST to 'http://localhost:5001' is aligned with your environment expectations and will not inadvertently affect production workflows.
export const APP_HOST = getServerRuntimeConfig('APP_HOST', 'http://localhost:5001');

Copy link
Copy Markdown
Contributor

@vigneshrajsb vigneshrajsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for these!! super useful updates.

let's merge and work on rough edges if identified.
happy to support anything needed as fast follow

@vmelikyan vmelikyan merged commit ae00185 into main Jun 27, 2025
1 check passed
@vmelikyan vmelikyan deleted the native-build-and-helm branch July 19, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants