Skip to content

fix: clarify PR env override examples#162

Merged
vigneshrajsb merged 5 commits intomainfrom
codex/improve-pr-env-override-guidance
Apr 14, 2026
Merged

fix: clarify PR env override examples#162
vigneshrajsb merged 5 commits intomainfrom
codex/improve-pr-env-override-guidance

Conversation

@vigneshrajsb
Copy link
Copy Markdown
Contributor

Summary

Improves the PR status comment guidance for environment overrides so the examples are clearer and safer to copy.

What Changed

  • replaced the single inline example with a short commented instruction block
  • added two dummy examples: a boolean flag and a lifecycle-themed URL
  • made the parser trim each line instead of removing all spaces, so values with spaces are preserved
  • added focused tests proving commented examples are ignored and real ENV: lines still parse correctly

Why

Users were getting confused by the existing example format, and the parser behavior around spaces was stricter than necessary.

Validation

  • pnpm test -- --runTestsByPath src/server/lib/__tests__/comment.test.ts

@vigneshrajsb vigneshrajsb force-pushed the codex/improve-pr-env-override-guidance branch from 3cd2ad8 to dfbdb14 Compare April 14, 2026 21:58
@vigneshrajsb vigneshrajsb marked this pull request as ready for review April 14, 2026 21:59
@vigneshrajsb vigneshrajsb requested a review from a team as a code owner April 14, 2026 21:59
@vigneshrajsb vigneshrajsb changed the title [codex] clarify PR env override examples fix: clarify PR env override examples Apr 14, 2026
@vigneshrajsb vigneshrajsb merged commit f29a236 into main Apr 14, 2026
1 check passed
@vigneshrajsb vigneshrajsb deleted the codex/improve-pr-env-override-guidance branch April 14, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant