fix: allow deprecated service-level YAML keys#169
Merged
vigneshrajsb merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
vigneshrajsb
changed the title
vigneshrajsb
added a commit
that referenced
this pull request
Apr 16, 2026
This reverts commit 8fe7693.
vigneshrajsb
added a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change relaxes service-level YAML schema validation so deprecated keys such as
kedaScaleToZerono longer fail validation.What changed
services[].additionalPropertiestotruein the 1.0.0 schemakedaScaleToZerovalidates as a no-opWhy
Some dependent repos still include deprecated service-level keys. After the schema cleanup, those configs started failing validation even though the deprecated fields are no longer used at runtime.
This keeps validation backward-compatible while those repos are cleaned up.
Follow-up
After the dependent config cleanup is complete, we should revert this compatibility change and restore stricter service-level schema validation.
Verification
pnpm test -- src/server/models/config/index.test.tsTradeoff
Service-level validation is now more permissive, so unknown top-level service keys will no longer be rejected by schema validation.