fix: validate build uuid overrides#197
Merged
vigneshrajsb merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
vmelikyan
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OverrideService.updateBuildUuidso all callers get the same safety check.PATCH /api/v2/builds/{uuid}for updating build UUIDs using the v2 response shape.Root Cause
PR comment edits could update a build UUID without checking whether the requested UUID was already used by another build. That allowed duplicate UUID changes to reach build/deployable/deploy update logic and cause downstream conflicts.
Validation
pnpm test -- --runTestsByPath src/server/services/__tests__/activityStream.test.ts 'src/app/api/v2/builds/[uuid]/route.test.ts'pnpm run lintpnpm run ts-checkwas run and still fails on existing repo-wide TypeScript strictness issues unrelated to this change.