feat: reconcile deleted yaml services#198
Merged
vigneshrajsb merged 3 commits intomainfrom May 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
features.reconcileDeletedServicesDeployCleanupServicefor deploy-scoped infra cleanup and stale service row deletionskipDeletedServiceReconciliationthrough the API redeploy, resolve queue, and build queue pathSafety
resolvedFromRepositoryIdrepositoryId = nulldeployables are skipped during repo-filtered reconciliationrepositoryId = nulldeployables after YAML import succeedsconfigurationdeployables are excluded from stale cleanupTests
repositoryId = nullservicestorn_downonly on full successValidation
pnpm run lintpassedpnpm exec jest src/server/services/__tests__/build.test.ts --runInBandpassedpnpm run test -- src/server/services/__tests__/build.test.ts src/server/services/__tests__/deployCleanup.test.ts src/server/services/__tests__/deployable.test.tspassedBUILD_MODE=yes DATABASE_URL=postgresql://lifecycle:lifecycle@localhost:5434/lifecycle APP_DB_HOST=localhost APP_DB_PORT=5434 APP_DB_USER=lifecycle APP_DB_PASSWORD=lifecycle APP_DB_NAME=lifecycle APP_DB_SSL=false pnpm run testpassedpnpm run ts-checkwas run and still fails with repo-wide existing TypeScript strictness errors unrelated to the stale reconciliation changespnpm exec jest --runInBandwas run after the final redeploy-path fix and failed in this shell because many suites requireDATABASE_URL/ APP DB env; focused regression tests passed