Skip to content

chore: replace bull with bullmq#29

Merged
vigneshrajsb merged 2 commits intomainfrom
bullmq-migrate
Aug 5, 2025
Merged

chore: replace bull with bullmq#29
vigneshrajsb merged 2 commits intomainfrom
bullmq-migrate

Conversation

@vigneshrajsb
Copy link
Copy Markdown
Contributor

What

replaces the older bull package with bullmq for latest features, support and fixes

for future: we might be able to dedupe updates that are back to back in quick succession if needed

@vigneshrajsb vigneshrajsb requested a review from a team as a code owner July 28, 2025 18:43
@vigneshrajsb vigneshrajsb requested a review from Copilot July 28, 2025 20:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from the legacy bull package to the modern bullmq package for queue management, providing better features, support, and fixes. The migration involves updating queue creation patterns, worker registration, and job processing methods across the codebase.

  • Replaces Bull with BullMQ queue and worker architecture
  • Updates queue configuration to use connections instead of createClient functions
  • Modernizes job processing methods to remove the done callback pattern

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/shared/config.ts Centralizes queue names in a QUEUE_NAMES constant object
src/server/lib/queueManager.ts Complete rewrite to support BullMQ Queue and Worker separation
src/server/lib/redisClient.ts Updates Redis client creation for BullMQ compatibility
src/server/services/*.ts Updates all service classes to use new BullMQ patterns
src/server/jobs/index.ts Migrates job bootstrapping to use registerWorker instead of process methods
src/pages/api/**/*.ts Updates API endpoints to include job names when adding jobs
package.json Replaces bull dependency with bullmq
Comments suppressed due to low confidence (1)

src/server/services/build.ts:1193

  • The variable assignment jobId = job?.data?.buildId is confusing since jobId suggests it should contain a job identifier, but it's actually assigned a build ID.
      jobId = job?.data?.buildId;

Comment thread src/server/services/pullRequest.ts
Comment thread src/server/services/build.ts
Comment thread src/server/services/activityStream.ts
Comment thread src/server/services/activityStream.ts
@vigneshrajsb
Copy link
Copy Markdown
Contributor Author

tested the changes extensively with container and elasticache redis.. should be no-op replacement if redis version > 6

@vigneshrajsb vigneshrajsb merged commit a7d6257 into main Aug 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants