chore: replace bull with bullmq#29
Merged
vigneshrajsb merged 2 commits intomainfrom Aug 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from the legacy bull package to the modern bullmq package for queue management, providing better features, support, and fixes. The migration involves updating queue creation patterns, worker registration, and job processing methods across the codebase.
- Replaces Bull with BullMQ queue and worker architecture
- Updates queue configuration to use connections instead of createClient functions
- Modernizes job processing methods to remove the
donecallback pattern
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/config.ts | Centralizes queue names in a QUEUE_NAMES constant object |
| src/server/lib/queueManager.ts | Complete rewrite to support BullMQ Queue and Worker separation |
| src/server/lib/redisClient.ts | Updates Redis client creation for BullMQ compatibility |
| src/server/services/*.ts | Updates all service classes to use new BullMQ patterns |
| src/server/jobs/index.ts | Migrates job bootstrapping to use registerWorker instead of process methods |
| src/pages/api/**/*.ts | Updates API endpoints to include job names when adding jobs |
| package.json | Replaces bull dependency with bullmq |
Comments suppressed due to low confidence (1)
src/server/services/build.ts:1193
- The variable assignment
jobId = job?.data?.buildIdis confusing sincejobIdsuggests it should contain a job identifier, but it's actually assigned a build ID.
jobId = job?.data?.buildId;
Contributor
Author
|
tested the changes extensively with container and elasticache redis.. should be no-op replacement if redis version > 6 |
vmelikyan
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
replaces the older
bullpackage withbullmqfor latest features, support and fixesfor future: we might be able to dedupe updates that are back to back in quick succession if needed