fix: labels update in queue to avoid race conditions#31
Merged
vigneshrajsb merged 2 commits intomainfrom Aug 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a queue-based system for managing PR label updates to prevent race conditions when adding deploy labels before GitHub comments are created and posted.
- Adds a new
LabelServicewith a dedicated queue for handling label operations asynchronously - Replaces direct GitHub API calls for label updates with queued jobs that can wait for comment creation
- Implements proper error handling and retry logic for label operations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/config.ts | Adds LABEL queue name configuration |
| src/server/services/types/index.ts | Adds LabelService to the services interface |
| src/server/services/label.ts | Creates new LabelService with queue-based label management |
| src/server/services/index.ts | Instantiates LabelService in the services factory |
| src/server/services/github.ts | Replaces direct label API calls with queued label jobs |
| src/server/jobs/index.ts | Registers the label queue worker with proper concurrency |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
To avoid race condition when adding the deploy label before the github comment is created and posted.