fix: misc fixes for codefresh, native build image and helm deploys#33
Merged
vigneshrajsb merged 7 commits intomainfrom Aug 14, 2025
Merged
fix: misc fixes for codefresh, native build image and helm deploys#33vigneshrajsb merged 7 commits intomainfrom
vigneshrajsb merged 7 commits intomainfrom
Conversation
- for now using the config from app_setup.org. this still can be empty with current setup - when we build the onboarding flow, maybe make this required so this config value can never be empty!
vmelikyan
approved these changes
Aug 11, 2025
no history on why we added this for now, so to handle external ECR setups, we dont want to add a suffix to the image name generated. we need to test this change with codefresh and buildkit to make sure this doesnt break anything
vigneshrajsb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
app_setup.orgthat will be populated when setting up the app in a github org. this is assuming that the custom clone and kube-context steps have the same org namespaceassumption:
git-branchannotation value to handle for special characters--versionto helm install commands for public and org charts since globalConfig or lifecycle config can have pinned versions for a chart_PS: