Activity

1. hadyan commented on Jun 19, 2023

   

   hadyan

   on Jun 19, 2023

   Contributor

   More actions

   Thanks for the details @kireerik.

   I added the prerenderAndPrefetch option to example/index/index/site/index/main.js#L10

   

   and it looks like the resume page is still prefetched as expected, speculation rules is injected and the page is prerendered:

   

   Just a side note that the latest quicklink release has not included the update to remove 1 prerender limit, hence the resume page is not included in the speculation rules.

   Did you try with prerenderAndPrefetch or any other option to enable prerendering mode?
2. kireerik commented on Jun 20, 2023

   

   kireerik

   on Jun 20, 2023

   Author

   More actions

   I tried the prerender option. Now I see that the script is added in that case as well. However it seems like the (added) page is not prerendered.

   Can you release

   • Fix Prerender Support #348

   ?
3. kireerik commented on Jun 20, 2023

   

   kireerik

   on Jun 20, 2023

   Author

   More actions

   performance.getEntriesByType('navigation')[0].activationStart is 0 (related article section: https://developer.chrome.com/blog/prerender-pages/#detecting-prerender-in-javascript)
4. hadyan commented on Jul 3, 2023

   

   hadyan

   on Jul 3, 2023

   Contributor

   More actions

   I tried the prerender option. Now I see that the script is added in that case as well. However it seems like the (added) page is not prerendered.

   @kireerik Great to see that the prerender option works to add the speculation rules on your page. Which tool did you use to observe whether the page is prerendered successfully. This new preloading panel in DevTools and testing it in Canary will be the most reliable way to test.

   Can you release

   • Fix Prerender Support #348

   ?

   As for the release, hope it can be released soon too. @XhmikosR / @addyosmani have you planned for the next release yet? Thank you!
5. XhmikosR commented on Aug 14, 2023

   

   XhmikosR

   on Aug 14, 2023

   Last edited by XhmikosR

   Collaborator

   More actions

   @hadyan: IIRC, @addyosmani wanted to make the next version a minor release (I personally would land any other breaking changes and make it v3.0.0 to be safe since the dist file filenames have changed IIRC).

   I don't have push rights on npm AFAICT so it's up to @addyosmani to cut the new version :)