Skip to content

Conversation

@aasthabharill
Copy link
Member

Improve documentation for shardingContextFilePath variable

Improve documentation for shardingContextFilePath variable
@aasthabharill aasthabharill requested a review from a team as a code owner September 15, 2025 07:47
@aasthabharill aasthabharill added the bug Something isn't working label Sep 15, 2025
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 55.94059% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.41%. Comparing base (c596a7e) to head (9bad628).
⚠️ Report is 184 commits behind head on main.

Files with missing lines Patch % Lines
...loud/teleport/plugin/maven/TemplatesStageMojo.java 42.52% 45 Missing and 5 partials ⚠️
...gle/cloud/teleport/plugin/maven/PromoteHelper.java 7.14% 26 Missing ⚠️
...gle/cloud/teleport/v2/kafka/utils/KafkaConfig.java 0.00% 22 Missing ⚠️
...le/cloud/teleport/spanner/spannerio/SpannerIO.java 14.28% 12 Missing ⚠️
...oogle/cloud/teleport/templates/PubSubToSplunk.java 47.61% 11 Missing ⚠️
...ud/teleport/it/iceberg/IcebergResourceManager.java 89.69% 7 Missing and 3 partials ⚠️
...cloud/teleport/v2/kafka/utils/KafkaTopicUtils.java 0.00% 10 Missing ⚠️
...port/v2/transforms/BigQueryDynamicDestination.java 0.00% 7 Missing ⚠️
...he/beam/it/gcp/spanner/SpannerResourceManager.java 0.00% 6 Missing ⚠️
...oud/teleport/v2/utils/DatastreamToPostgresDML.java 16.66% 1 Missing and 4 partials ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2775      +/-   ##
============================================
+ Coverage     49.90%   50.41%   +0.50%     
- Complexity     4942     5399     +457     
============================================
  Files           967      970       +3     
  Lines         59186    59609     +423     
  Branches       6419     6507      +88     
============================================
+ Hits          29536    30051     +515     
+ Misses        27553    27436     -117     
- Partials       2097     2122      +25     
Components Coverage Δ
spanner-templates 70.65% <77.35%> (+0.46%) ⬆️
spanner-import-export 69.00% <76.05%> (+0.41%) ⬆️
spanner-live-forward-migration 80.03% <80.00%> (+0.31%) ⬆️
spanner-live-reverse-replication 77.46% <ø> (+0.46%) ⬆️
spanner-bulk-migration 88.25% <ø> (+0.03%) ⬆️
Files with missing lines Coverage Δ
...c/main/java/org/apache/beam/it/gcp/JDBCBaseIT.java 0.00% <ø> (ø)
...va/com/google/cloud/teleport/spanner/AvroUtil.java 93.75% <ø> (ø)
...ava/com/google/cloud/teleport/spanner/ddl/Ddl.java 77.50% <100.00%> (+1.81%) ⬆️
.../cloud/teleport/spanner/ddl/GraphElementTable.java 86.66% <100.00%> (+1.72%) ⬆️
...ogle/cloud/teleport/spanner/ddl/PropertyGraph.java 85.85% <100.00%> (+1.98%) ⬆️
...cloud/teleport/v2/cdc/mappers/BigQueryMappers.java 0.00% <ø> (ø)
...loud/teleport/v2/transforms/DLQWriteTransform.java 97.29% <100.00%> (+0.15%) ⬆️
...rt/v2/templates/datastream/ChangeEventContext.java 92.85% <100.00%> (+4.62%) ⬆️
...emplates/datastream/OracleChangeEventSequence.java 80.95% <100.00%> (ø)
...plates/datastream/PostgresChangeEventSequence.java 84.31% <100.00%> (ø)
... and 28 more

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasthabharill aasthabharill added improvement and removed bug Something isn't working labels Dec 10, 2025
Abacn and others added 17 commits December 10, 2025 11:48
Co-authored-by: liferoad <7833268+liferoad@users.noreply.github.com>
* checkstyle bump 11.0.1

* checkstyle bump 11.0.1
* Update generate_dependencies.sh

* Update generate_dependencies.sh

* remove the version
* Spanner to SourceDb: Pubsub failure injection test

* Adding UT

* Corrected compilation failure
Co-authored-by: liferoad <7833268+liferoad@users.noreply.github.com>
#2768)

* SourceDb to Spanner: Bulk migration + dlq Retry failure injection test

* Addressing comments
The previous sed command only handled decimal test times but not integer ones. Update the command to properly process both integer and decimal time formats in surefire reports.
* Introduce Schemaless graphs to import/export DDL

- Introduces the concepts of DYNAMIC LABEL and DYNAMIC PROPERTIES
- Adds a DdlTest to test new fields

- Next: Add Avro<->Schema converters

* Add converters for dynamic PropertyGraphs

- To and from Avro

Next: Minor change for updating INFORMATION SCHEMA

* Recognize dynamic labels/props from Spanner Graph Information Schema

- Added a test to verify that it works correctly

* Apply mvn spotless

---------

Co-authored-by: Sailesh Mukil <mukil.sailesh@gmail.com>
Bumps [github.com/hashicorp/terraform-json](https://github.com/hashicorp/terraform-json) from 0.26.0 to 0.27.2.
- [Release notes](https://github.com/hashicorp/terraform-json/releases)
- [Commits](hashicorp/terraform-json@v0.26.0...v0.27.2)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-json
  dependency-version: 0.27.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2770)

Bumps [io.opencensus:opencensus-api](https://github.com/census-instrumentation/opencensus-java) from 0.24.0 to 0.31.1.
- [Release notes](https://github.com/census-instrumentation/opencensus-java/releases)
- [Changelog](https://github.com/census-instrumentation/opencensus-java/blob/master/CHANGELOG.md)
- [Commits](census-instrumentation/opencensus-java@v0.24.0...v0.31.1)

---
updated-dependencies:
- dependency-name: io.opencensus:opencensus-api
  dependency-version: 0.31.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.awaitility:awaitility](https://github.com/awaitility/awaitility) from 4.2.0 to 4.3.0.
- [Changelog](https://github.com/awaitility/awaitility/blob/master/changelog.txt)
- [Commits](awaitility/awaitility@awaitility-4.2.0...awaitility-4.3.0)

---
updated-dependencies:
- dependency-name: org.awaitility:awaitility
  dependency-version: 4.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… transaction (#2789)

* DataStreamToSpanner - Adding main table read at the beginning of main transaction

* Addressing comments

* Spotless fix
* updated CPU priority to HIGH for reverse replication jobs

* taken priority as option

* spotless check

---------

Co-authored-by: Aditya Bharadwaj <adibh@google.com>
derrickaw and others added 24 commits December 10, 2025 11:48
…ot used (#2887)

* remove todos for 2.68 and gax

* resolve conflicts
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.6 to 4.31.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@fe4161a...cf1bb45)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#3063)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.9 to 7.0.11.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@84ae59a...22a9089)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-version: 7.0.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps com.google.apis:google-api-services-dataplex from v1-rev20250924-2.0.0 to v1-rev20251113-2.0.0.

---
updated-dependencies:
- dependency-name: com.google.apis:google-api-services-dataplex
  dependency-version: v1-rev20251113-2.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `jetty.version` from 12.1.4 to 12.1.5.

Updates `org.eclipse.jetty:jetty-http` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-server` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-client` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-io` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-util` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-security` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-util-ajax` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-xml` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty:jetty-alpn-client` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty.ee8:jetty-ee8-servlet` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty.ee8:jetty-ee8-webapp` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty.websocket:jetty-websocket-jetty-api` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty.websocket:jetty-websocket-jetty-client` from 12.1.4 to 12.1.5

Updates `org.eclipse.jetty.websocket:jetty-websocket-jetty-common` from 12.1.4 to 12.1.5

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-http
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-server
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-client
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-io
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-util
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-security
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-util-ajax
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-xml
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-alpn-client
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.ee8:jetty-ee8-servlet
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.ee8:jetty-ee8-webapp
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.websocket:jetty-websocket-jetty-api
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.websocket:jetty-websocket-jetty-client
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.websocket:jetty-websocket-jetty-common
  dependency-version: 12.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add check for small machines

* Remove log

* Apply spotless

* Use Preconditions

* Update IT and LT base classes with workerMachineType

* Add to params instead of env
…#3070)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ta type support (#3055)

* Add data types test for live migration from MySQL to a Spanner dialect Spanner DB

* Add data types test for live migration from MySQL to a Postgres dialect Spanner DB
#3075)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
bump version of maven packages from 3.6.3 to 3.9.9 to address https://nvd.nist.gov/vuln/detail/CVE-2021-26291 vulnerability
…3081)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…er (#3083)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… change event (#3034)

[b/464837828](https://b.corp.google.com/issues/464837828)
Spanner allows NULL values in Primary key columns (From documentation: "For GoogleSQL-dialect databases, primary key columns are usually annotated with NOT NULL (though you can omit this annotation if you want to allow NULL values in key columns.").

Scenario: Insert a row in Spanner in which one of the PK columns is nullable and has value NULL.

Current behaviour: The query errors out with severe error in AssignShardId step and DLQ ```com.google.cloud.teleport.v2.spanner.migrations.exceptions.ChangeEventConvertorException: Required key userId not found in change event, Caused by: Required key userId not found in change event```

Problem: This error message is incorrect as the changestream shouldnt error out, the source should (in case NULL is not supported)

Expected Behaviour: A row with null PK should pass through spanner and changestream to source and then error out if source does not support NULLs in primary key columns.

 
### Testing
Tested by making a flex container image:  gs://ea-functional-tests/templates-aastha-2025-08-12/flex/Spanner_to_SourceDb

After changes, on inserting a row in Spanner with a compound PK in which one of the PK columns is nullable and has value NULL, this is the retriable error that is inserted in DLQ:
```
{"message":{"commitTimestamp":{"seconds":1765176539,"nanos":325359000},"serverTransactionId":"MTY5NTE4NTU3MjYzOTg1OTM4NQ==","recordSequence":"00000000","tableName":"unified_lgm_event_data","mod":{"keysJson":"{\"ddrkey\":\"-532\",\"slotId\":\"50\",\"userId\":null}","oldValuesJson":"{}","newValuesJson":"{\"attempts\":\"70\",\"createTime\":\"0\",\"eventId\":\"80\",\"intAttrib0\":\"-1\",\"intAttrib1\":\"-1\",\"intAttrib2\":\"-1\",\"intAttrib3\":\"-1\",\"intAttrib4\":\"-1\",\"intAttrib5\":\"-1\",\"intAttrib6\":\"-1\",\"intAttrib7\":\"-1\",\"intAttrib8\":\"-1\",\"intAttrib9\":\"-1\",\"lastAttemptedTime\":\"0\",\"lastCompletedTime\":\"0\",\"lastUpdateTime\":\"0\",\"round\":\"80\",\"status\":\"60\",\"stringAttrib0\":\"\",\"stringAttrib1\":\"\",\"stringAttrib2\":\"\",\"stringAttrib3\":\"\",\"stringAttrib4\":\"\",\"timesAttemptedInInterval\":\"0\"}"},"modType":"INSERT","numberOfRecordsInTransaction":1,"transactionTag":"","shard":"shard1_00","isRetryRecord":false,"_metadata_retry_count":0},"error_message":"UNKNOWN: Column 'userId' cannot be null, Caused by: Column 'userId' cannot be null"}
```
* add YEAR mapping

* orrect expectedData for YEAR column

* fix spotless error
* Update PromoteHelper to use PUBLIC_BCID_VSA_ONLY

* Update PromoteHelperTest.java
* Add IcebergResourceManager

* Add IcebergResource Manager for IT

* Fix Testcase

* Order fields

* Apply spotless

* Add Unit tests

* Apply Spotless

* Add Postgres to Iceberg

* Add Pipeline Options

* fix options

* fix options

* Add Postgres to Iceberg Template

* Add test case for framework

* Fix Tests

* spotless

* Fix dependency

* Fix failing test

* Fix names

* Fix data type

* Add Iceberg setup beforehand

* use GCS Bucket for warehouse

* Use base path

* move to Rest Catalog

* use random bucket for concurrent test runs

* Fix GcsResourceManager Cleanup
…3086)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: liferoad <7833268+liferoad@users.noreply.github.com>
@aasthabharill aasthabharill requested review from a team as code owners December 10, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.