Making Spanner ITs run on dedicated project #2803
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
============================================
+ Coverage 50.79% 50.85% +0.05%
- Complexity 5122 5510 +388
============================================
Files 976 976
Lines 60058 60100 +42
Branches 6569 6574 +5
============================================
+ Hits 30509 30564 +55
+ Misses 27407 27383 -24
- Partials 2142 2153 +11
🚀 New features to boost your workflow:
|
darshan-sj
force-pushed
the
spanner-pr-on-new-project
branch
from
11ac51d to
94dd7c0
Compare
darshan-sj
force-pushed
the
spanner-pr-on-new-project
branch
3 times, most recently
from
b2bb7ab to
9f02241
Compare
darshan-sj
force-pushed
the
spanner-pr-on-new-project
branch
from
9f02241 to
0da86af
Compare
bharadwaj-aditya
left a comment
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
Added a few comments, but i don't completely understand the flow here.
| pip install -r test-infra/requirements.txt | ||
| - name: Run cleanup_pubsub_notifications.py | ||
| run: python test-infra/cleanup_pubsub_notifications.py | ||
| run: python test-infra/cleanup_pubsub_notifications.py --project cloud-teleport-testing |
There was a problem hiding this comment.
Shouldn't this be span-cloud-teleport-testing ?
There was a problem hiding this comment.
The span-cloud-teleport-testing project is there in line 67 and 69. We have some tests like DatastreamToSql and the Import/export tests run on old project for which cleanup pubsub notifications and cleanup spanner databases scripts need to be run on the old cloud-teleport-testing project.
| // Example output: | ||
| // [0.005s][warning][perf,memops] Cannot use file /tmp/hsperfdata_runner/109499 ... | ||
| // /home/runner/.m2/repository | ||
| String[] lines = basePath.split("\\r?\\n"); |
There was a problem hiding this comment.
This seems very specific. How do we make sure it covers all cases of output ?
There was a problem hiding this comment.
Correct the logic and made it generic. Actually this is a side bug fix, and not directly related to "Making Spanner ITs run on dedicated project" work.
| this.instanceId = randomInstanceName; | ||
| } else if (System.getProperty("spannerInstanceId") != null) { | ||
| || Objects.equals(projectId, "span-cloud-teleport-testing")) { | ||
| if (Strings.isNullOrEmpty(System.getProperty("spannerInstanceId")) |
There was a problem hiding this comment.
who sets the spannerInstanceId ?
Can you add the flow to the comments / PR ?
There was a problem hiding this comment.
The spannerInstanceId is set in the maven command run to execute the integration tests. For the scheduled runs it is set in the go lang code in the cicd/cmd/ folder which generates and executes the tests for the github action workflows.
2 participants
No description provided.