-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add integration tests to verify table and index limits for live spanner migration from PostgreSQL #3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add integration tests to verify table and index limits for live spanner migration from PostgreSQL #3107
Conversation
…migration from a MySQL database to a Spanner instance This includes tests for the following limits: - max size of a STRING cell - max size of a data per cell - max size of a primary key - max size of an index - total size of non-key columns (currently ignored because of OOM issues with low-provisioned VMs/DBs)
Summary of ChangesHello @nmemond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the testing suite for the DataStreamToSpanner Flex template by introducing a series of integration tests. These tests are designed to rigorously validate the template's ability to handle various data size and structural limits when migrating live data from PostgreSQL and MySQL databases to Spanner, supporting both Spanner's GoogleSQL and PostgreSQL dialects. The primary goal is to ensure robust data integrity and migration success even with challenging data characteristics like extremely large keys, cells, or wide tables. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
e9c3a59 to
79ebae8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3107 +/- ##
============================================
+ Coverage 50.48% 54.20% +3.72%
+ Complexity 5040 2157 -2883
============================================
Files 973 488 -485
Lines 59721 28151 -31570
Branches 6511 2946 -3565
============================================
- Hits 30149 15260 -14889
+ Misses 27443 11954 -15489
+ Partials 2129 937 -1192
🚀 New features to boost your workflow:
|
79ebae8 to
0d411f0
Compare
0d411f0 to
7d2785f
Compare
…migration from a PostgreSQL DB
7d2785f to
f9bebcc
Compare
This PR is built on top of #3037, that PR should be reviewed and merged first.
This adds integration tests to verify table and index limits during live spanner data migration from a PostgreSQL DB.
This includes tests for the following limits: